Patch: move power-x86-destdir.patch to a section where it is applied even for vanilla builds

Thorsten Leemhuis fedora at leemhuis.info
Sat Oct 20 18:33:46 UTC 2012


Hi!

power-x86-destdir.patch should be applied always, as building the Fedora
spec file with the switch "--with vanilla" will fail otherwise. Attached
patch fixes that for rawhide.

BTW: is that patch heading upstream?

While at it: Is it really a good idea to put the definitions for Fedora
specific patches in a section with a "%if !%{nopatches}" conditional? If
someone grabs the SRPM from a vanilla build then he can't properly
recompile it without using "--with vanilla", as the SRPM misses the
patches for a proper Fedora build. Sure, that's a corner case, but the
space saving from omitting the patches are not that big, so I was
wondering if this "%if !%{nopatches}" conditional is better removed, as
it's not worth the trouble.

Cu
knurd


More information about the kernel mailing list