[PATCH] kernel.spec: let flavors/variants end with "+$flavor" in the uname

[Thorsten Leemhuis]

Hi!

Harald Hoyer wrote on 14.06.2013 16:02:
> On 06/13/2013 09:08 AM, harald at redhat.com wrote:
>> 
>> This patch changes the version of kernel flavor/variants to end
>> in "+$flavor" instead of ".$flavor". This makes it easier to detect
>> a flavor and a parser can separate it from the architecture.
>> 
>> With that change we can correct kernel-install (of systemd) to call
>> new-kernel-package with --package kernel-$flavor, because the $flavor
>> can easily be extracted from the version string.
>> ---
>> 
>> After talking to the rpm team, "+" is the only char left as a separator.
>> 
>> Kernel compiles and runs:
>> $ uname -r
>> 3.10.0-0.rc5.git0.1.fc20.x86_64+debug
>> $ echo /lib/modules/*debug
>> /lib/modules/3.10.0-0.rc5.git0.1.fc20.x86_64+debug
> 
> Any comments?

I'll bite, even if I'm just a interested party. The + kind of looks ugly
to me. In your initial mail ("Patch for kernel variants/flavors") you wrote

> Another solution would be to name the default kernel to have a flavor
> "default" like SUSE does, but this does not look nice.

I'd prefer something like that, as it's imho less ugly (or just as ugly)
than the plus and makes a lot of things easier. Agreeing on a name might
require a round of bike shedding if the Fedora developers want to go
down that route. "default", "generic" describe it well, but otoh might
make people think it's just ordinary and "meh". My vote goes to
"generic" for now.

CU
knurd