[kernel] Add patch for i.MX6 Utilite device dtb, drop old exynos patch

Josh Boyer jwboyer at fedoraproject.org
Wed Oct 30 10:59:25 UTC 2013


On Wed, Oct 30, 2013 at 4:00 AM, Amit Shah <amitshah at gmx.net> wrote:
> On (Thu) 24 Oct 2013 [16:02:31], Josh Boyer wrote:
>> On Thu, Oct 24, 2013 at 3:48 PM, Josh Boyer <jwboyer at fedoraproject.org> wrote:
>> > On Thu, Oct 24, 2013 at 3:29 PM, Peter Robinson
>> > <pbrobinson at fedoraproject.org> wrote:
>> >> diff --git a/config-arm-generic b/config-arm-generic
>> >> index 96a95e5..aaa88ee 100644
>> >> --- a/config-arm-generic
>> >> +++ b/config-arm-generic
>> >> @@ -114,8 +114,6 @@ CONFIG_MFD_CORE=m
>> >>  CONFIG_SMC91X=m
>> >>  CONFIG_SMC911X=m
>> >>
>> >> -CONFIG_VIRTIO_CONSOLE=m
>> >> -
>> >
>> > Why did this get dropped?  The commit message doesn't say.
>>
>> I think I figured this part out, but the commit message should have
>> mentioned it.  Doesn't necessarily have to be in %changelog, but
>> should be mentioned in the commit log.
>
> What's the reason?

I believe it's because we have CONFIG_VIRTIO_CONSOLE=m set in
config-generic, and all the architectures that don't override it will
inherit that.  So the setting in config-arm-generic is redundant.
Commit log should still mention it though, as the config-* merging is
somewhat black magic and if you don't know how it works it looks like
it was just disabled.

josh


More information about the kernel mailing list