[PATCH v2] [RESEND] Enable USB gadget subsystem outside ARM

Peter Robinson pbrobinson at gmail.com
Wed Mar 5 20:14:37 UTC 2014


>>> It's generally useful. On other architectures the UDC capable hardware might
>>> not be very common, but the dummy HCD makes it possible to use such hardware
>>> for development and emulation of USB gadget driver code.
>>
>> ACK from me
>
> I'm not at all sold on this to be honest.  Coverity just picked up a
> bunch of issues in this subsystem during the last merge window and the
> overall USB subsystem maintainer doesn't even enable these drivers in
> his build testing.  It seems to be a lot of churn for very little
> gain.
>
> Also, if the dummy HCD driver is the only marginally useful thing on
> x86, why copy all of the stuff in the ARM config blindly?  Isn't it
> feasible to enable GADGET and HCD on x86 and leave everything else
> off?

>From my PoV I want it in the ARM core package and not in extras as it
will break stuff for us. I'm ACKing that it won't break any of our
expected ARM use cases. From an x86 and coverity PoV I can't comment
other than ask how is it different from any other corner case modules.

Peter


More information about the kernel mailing list