[PATCH] Add rd.memdebug in kdump module

WANG Chao chaowang at redhat.com
Wed Nov 20 07:06:49 UTC 2013


On 11/20/13 at 01:26pm, Dave Young wrote:
> On 11/20/13 at 01:09pm, WANG Chao wrote:
> > On 11/19/13 at 03:26pm, Zhi Zou wrote:
> > >     Description:
> > >        Currently we only added memdebug code before different dracut
> > >     hooks ie. pre-udev pre-pivot etc. Add memdebug in kdump.sh before
> > >     capturing vmcore is also good for debugging.
> > > 
> > >     solution:
> > >        Add make_trace_mem before saving vmcore.
> > 
> > How much will we benefit from this while we've already got a debug point
> > at pre-pivot?
> 
> There's some gap between pre-pivot and actual dumping, there's might be
> other memory consuming apps runs in this gap.

OK. Then I'm fine with patch.

> 
> OTOH, it will be good for simply check the memdebug messages only at this point
> for convinience.
> 
> > 
> > Thanks
> > Chao
> > 
> > > ---
> > >  dracut-kdump.sh | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/dracut-kdump.sh b/dracut-kdump.sh
> > > index f38891d..d157cd1 100755
> > > --- a/dracut-kdump.sh
> > > +++ b/dracut-kdump.sh
> > > @@ -312,7 +312,7 @@ if [ $? -ne 0 ]; then
> > >      echo "kdump: kdump_pre script exited with non-zero status!"
> > >      do_final_action
> > >  fi
> > > -
> > > +make_trace_mem "kdump saving vmcore" '1:shortmem' '2+:mem' '3+:slab'
> > >  do_dump
> > >  DUMP_RETVAL=$?
> > >  
> > > -- 
> > > 1.8.3.1
> > > 
> > > _______________________________________________
> > > kexec mailing list
> > > kexec at lists.fedoraproject.org
> > > https://lists.fedoraproject.org/mailman/listinfo/kexec


More information about the kexec mailing list