[Patch v2 3/4] store the default dump target info when default target is a separate disk
Vivek Goyal
vgoyal at redhat.com
Thu Mar 20 15:07:05 UTC 2014
On Thu, Mar 20, 2014 at 03:39:28PM +0800, Dave Young wrote:
[..]
> > I don't like two different versions of get_persistent_dev(). I am
> > wondering why do we need to use get_persistent_dev() in mkdumprd at all?
> >
> > Will dracut not translate device names into persistent names
> > automatically. If yes, then we can probably get rid of
> > get_persistent_dev() logic from mkdumprd and use the one available from
> > dracut in dracut-module-setup.sh.
>
> Dracut will put the --mount fstab lines in initramfs without any change
> except the fsck default value.
>
> The code in mkdumprd is for creating udev dev name in initramfs /etc/fstab
> Moving it to dracus.sh is doable via replacing the 1st field of --mount
> with $(get_presistent_dev $dev) before appending the line to fstab file.
I am not sure if harald will like the idea of automatically converting
mount device name to persistent device name.
For us, it will work though.
So feel free to propose a patch which does that and then we can get rid
of all the code for get_persistent_dev() from mkdumprd.
Thanks
Vivek
More information about the kexec
mailing list