[Fedora-livecd-list] [PATCH] print out what urls are being downloaded, more verbose yum
Colin Walters
walters at redhat.com
Wed Aug 8 16:36:36 UTC 2007
On Wed, 2007-08-08 at 12:17 -0400, Jeremy Katz wrote:
> On Tue, 2007-08-07 at 17:44 -0400, Colin Walters wrote:
> > +class TextProgress(object):
> > + def start(self, filename, url, *args, **kwargs):
> > + print "Retrieving %s" % (url,)
> > + self.url = url
> > + def update(self, *args):
> > + pass
> > + def end(self, *args):
> > + print "Retrieved %s OK" % (self.url,)
>
> Why two lines for every package? Seems like we should be able to just
> have the retrieving when it starts (and no newline) and then "OK" when
> it completes.
Mainly because that creates the assumption that it will be the only
function showing output during that time.
> > @@ -189,7 +198,7 @@ class LiveCDYum(yum.YumBase):
> > conf += "installroot=%s\n" % installroot
> > conf += "cachedir=/var/cache/yum\n"
> > conf += "plugins=0\n"
> > - conf += "debuglevel=2\n"
> > + conf += "debuglevel=3\n"
> > conf += "reposdir=\n"
>
> What does debuglevel of 3 vs 2 give you? 2 is the default with yum, and
> I don't really know that making it higher for livecd-tools makes sense.
> It probably does, though, make sense to think about a --quiet and
> --verbose as we get more things which output more.
This change should probably not be included; I don't remember now why I
did that.
Anyways, this patch isn't really important; the only one I actually care
about is the caching patch.
More information about the livecd
mailing list