[Fedora-livecd-list] [PATCH] cleanupDeleted and container_size - saves 5.5% output size on f7livecd-i686

[Douglas McClendon]

Douglas McClendon wrote:
> Douglas McClendon wrote:
>> Attached is a patch.
>>  
> 
> ...
> 
>> Please review.  Any comments, suggestions, or criticisms are welcome.  
>> I still consider myself a relative novice when it comes to python.
>  
...

> a) is there really any reason to not make the container-size be 1T by 
> default, and not even have the option?  I guess I'll leave it as is for 
> now, but suggest that f8t1 ship with 1T if nobody can suggest any reason 
> not to.  Likewise for the overlay which is currently 512M.


Ok, the answer to this is that squashfs doesn't appear to be too brilliant about 
how it handles sparse files.  So 1T as default is out of the question.  Though 
making the mayflower initramfs overlay match the container still seems like a 
good idea.


> 
> d) given (b) and (c), and given that the benefits of cleanup-deleted are 
> so immense (5.5% on stock f7i686-livecd, 20+% on Patrice Guay's use 
> case), I think it should happen by default.
> 

make that 15%+, for those of you who know math :)

-dmc