[Fedora-livecd-list] ImageCreator "selinux --disable" problem

[Jeremy Katz]

On Tue, 2008-02-19 at 17:25 -0500, Warren Togami wrote:
> First I discovered places in kickstart.py where it is supposed to be
> checking that SELinux-from-kickstart file setting was always returning
> true.  I believe the attached patch fixes this part, although it could
> use some review.

Looks reasonable enough.

> To my dismay it continued to install with labels.  I then realized that
> creator.py's ImageCreator mount() method unconditionally bind mounted
> the system's /selinux directory, which is incorrect if "selinux
> --disabled" is defined in the kickstart file.
> 
> Perhaps my understanding of python is not advanced, but it appears that
> there is no good way to check kickstart's selinux setting from the
> mount() method due to the way it is abstracted.

It should work to take /selinux out of the list and then do
  if kickstart.selinux_enabled(self.ks):
     self.__bindmounts.append(BindChrootMount("/selinux",
self._instroot, None))

Does that not work?  And then also the macro change that we talked about
on IRC

Jeremy