[Fedora-livecd-list] Patch review request for black screen fix

[Mads Kiilerich]

On 07/26/2010 08:14 AM, Bruno Wolff III wrote:
> This patch will break builds with generic-logos and that package is updated
> to be consistent with fedora-logos. I suspect that will happen anyway, but
> if this patch is accepted, I'll be filing a but against generic-logos.
>
> The patch is attached and the commit log entry follows:
>      Change live.py to use the new location of the vesa splash image.
>
>      fedora-logos recently changed the location it uses for the vesa splash
>      image. This breaks (bug 615443) live images built using fedora-logos.
>      This patch changes the location that the image is fetched from to match
>      the one used by fedora-logos.
>
>      Note that generic-logos hasn't been changed to use the new location yet.
>      So this change will break live images built using generic-logos until
>      that package is updated to match fedora-logos in where it stores the
>      vesa splash image.

I think it would be better to be flexible and tolerant and avoid strict 
external requirements. See the attached patch.

generic-logos should be bugged anyway.

/Mads

-------------- next part --------------
A non-text attachment was scrubbed...
Name: newsplash.patch
Type: text/x-patch
Size: 766 bytes
Desc: not available
Url : http://lists.fedoraproject.org/pipermail/livecd/attachments/20100726/b9536258/attachment.bin