Zikula AuthFAS patch problem

Paul W. Frields stickster at gmail.com
Thu Jun 3 17:59:57 UTC 2010


On Thu, May 27, 2010 at 10:21:33AM -0400, Paul W. Frields wrote:
> Therre's another comparison error in the latest AuthFAS commit.  Patch
> attached for review and inclusion.
> 
> -- 
> Paul W. Frields                                http://paul.frields.org/
>   gpg fingerprint: 3DA6 A0AC 6D58 FEC4 0233  5906 ACDB C937 BD11 3717
>   http://redhat.com/   -  -  -  -   http://pfrields.fedorapeople.org/
>           Where open source multiplies: http://opensource.com

> From 0276573b625749c6c52184947023806e7131a234 Mon Sep 17 00:00:00 2001
> From: Paul W. Frields <stickster at gmail.com>
> Date: Thu, 27 May 2010 10:20:32 -0400
> Subject: [PATCH] Fix another comparison syntax error
> 
> ---
>  AuthFAS/pnuserapi.php |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/AuthFAS/pnuserapi.php b/AuthFAS/pnuserapi.php
> index 0bf273f..6274749 100644
> --- a/AuthFAS/pnuserapi.php
> +++ b/AuthFAS/pnuserapi.php
> @@ -45,7 +45,7 @@ function AuthFAS_userapi_login($args)
>      $found = false;
>      $admin = false;
>      for ($i = 0, $cnt = count($groups); $i < $cnt; $i++) {
> -        if ($groups[$i]['name'] = 'cla_done') {
> +        if ($groups[$i]['name'] == 'cla_done') {
>              error_log("FAS auth succeeded for $username", 0);
>              $found = true;
>          }
> -- 
> 1.7.0.1


Did Mateo or Drak ever pick up this patch?  I did apply this live to
publictest6, but it's not in the repo yet:

http://git.fedorahosted.org/git/?p=fedora-zikula.git

I'm assuming they're subscribed to this list, but if not, they should
be:  https://lists.fedoraproject.org/mailman/listinfo/logistics

-- 
Paul W. Frields                                http://paul.frields.org/
  gpg fingerprint: 3DA6 A0AC 6D58 FEC4 0233  5906 ACDB C937 BD11 3717
  http://redhat.com/   -  -  -  -   http://pfrields.fedorapeople.org/
          Where open source multiplies: http://opensource.com


More information about the logistics mailing list