filesystem patch

[Farkas Levente]

Richard W.M. Jones wrote:
> On Wed, Nov 26, 2008 at 10:33:38AM +0100, Farkas Levente wrote:
>> +NAME="_`basename $0|tr -- - _`"
>> +eval "`rpm --eval "%{$NAME}"`" "$@"
> 
> The quoting here is confusing.  How about using $(..) instead of `..` ?

$() is bash-izm:-(
inside `..` it's a subsell so " is protected by the subsell (ie. no need
for \",
around $@ the " is highly is always preferred.
so imho it's the best syntax.


>> Index: mingw32.sh
> 
> We need mingw32.csh too.  Nobody uses CSH, but it's tradition to
> provide both Bourne shell and C-shell compatible scripts.

the main problem here is that spec is bash like ie. %mingw32_env is only
good for bash and all other macro is good for only bash:-(
ie. there is no easy way to auto generate .csh that's why i leave it
empty. but it'd be useful to give a change to someone easily set the
current shell's env (and i can't any other way to do so just using alias).

-- 
  Levente                               "Si vis pacem para bellum!"