[Bug 490133] Review Request: mingw32-qwt

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=490133





--- Comment #2 from Richard W.M. Jones <rjones at redhat.com>  2009-03-13 13:41:38 EDT ---
Output of auto-buildrequires looks good.

rpmlint says:

mingw32-qwt.src:31: W: rpm-buildroot-usage %prep sed -i "s\LIBPATH\
$RPM_BUILD_ROOT%{_mingw32_libdir}\1" qwtconfig.pri
mingw32-qwt.src:32: W: rpm-buildroot-usage %prep sed -i "s\HEADERPATH\
$RPM_BUILD_ROOT%{_mingw32_includedir}/%{name1}\1" qwtconfig.pri
mingw32-qwt.src:33: W: rpm-buildroot-usage %prep sed -i "s\DOCKPATH\
$RPM_BUILD_ROOT%{_mingw32_docdir}/%{name1}\1" qwtconfig.pri
mingw32-qwt.src:34: W: rpm-buildroot-usage %prep #sed -i "s\QTDESIGNERPATH\
$RPM_BUILD_ROOT%{_qt4_plugindir}/designer\1" designer/designer.pro
mingw32-qwt.src:35: W: rpm-buildroot-usage %prep sed -i "s\QTDESIGNERPATH\
$RPM_BUILD_ROOT%{_mingw32_libdir}/qt4/plugins/designer\1" designer/designer.pro

I don't really see a way to avoid this.  Apparently
this will be a problem in the case of RPM "short circuiting"
but I have no idea what that is or if anyone uses it.

mingw32-qwt.src: W: mixed-use-of-spaces-and-tabs (spaces: line 10, tab: line 4)

Be nice to fix this.  Run the specfile through expand(1).

mingw32-qwt.noarch: E: arch-independent-package-contains-binary-or-object
/usr/i686-pc-mingw32/sys-root/mingw/lib/libqwt5.a
mingw32-qwt.noarch: E: arch-independent-package-contains-binary-or-object
/usr/i686-pc-mingw32/sys-root/mingw/lib/libqwtd5.a

These can be ignored.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.