[Bug 492110] Review Request: mingw32-libsigc++20 - MinGW Windows port of the typesafe signal framework for C++

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=492110





--- Comment #2 from Thomas Sailer <t.sailer at alumni.ethz.ch>  2009-03-29 16:41:03 EDT ---
Thank you for taking the review!

I have updated the spec and srpm files:
http://sailer.fedorapeople.org/mingw32-libsigc++20-2.2.2-6.fc11.src.rpm
http://sailer.fedorapeople.org/mingw32-libsigc++20.spec

> The specfile is written in legible English, but...
> ... the WTF comment is a bit inapproriate and should preferably be
> removed, the $libdir/$packagename is a standard place for
> architecture dependent headers, so its presence is not surprising

You are completely right, I didn't understand this comment either. I've deleted
it.

> two files have questionable permissions and give rpmlint warnings
> (see above). If possible these two should be fixed by removing
> executable permissions.

Ok, I've removed the exec permissions. Now I would really like to know why my
rpmlint hasn't found this...

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.