[Bug 492110] Review Request: mingw32-libsigc++20 - MinGW Windows port of the typesafe signal framework for C++

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=492110





--- Comment #6 from Mattias Ellert <mattias.ellert at fysast.uu.se>  2009-03-30 07:59:57 EDT ---
As I said the only two possibly relevant comment were the two warnings about
bad permissions. I said in my review that this should be fixed if it doesn't
break anything. My review comments were stated in such a way that if you could
give a good argument for it, I would be happy to leave the executable
permissions there if they are needed.

The page you quote in comment 5 says in the section about
spurious-executable-perm that things might break if the .a file does not have
executable permissions, and that the executable permissions are the default
output of the tools and that you want to keep it that way. That is fine with
me.

The page also gives a comment about the script-without-shebang for the .la
files. The text under this heading seems to be off topic. The text says that
the .la files should not be removed - which is already stated clearly in the
main MinGW Packaging Guidelines page. And totally fails to address the reason
for the rpmlint warning, which is that the .la file has executable permission.
If also the .la file needs to have executable permissions, it would be better
to repeat the comment from the section about spurious-executable-perm in this
section, than to state the redundant and irrelevant information it currently
contains.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.