[Bug 613993] Review Request: mingw32-celt051 - An audio codec for use in low-delay speech and audio communication

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=613993

--- Comment #4 from Erik van Pienbroek <erik-fedora at vanpienbroek.nl> 2010-08-07 18:14:31 EDT ---
Created an attachment (id=437382)
 --> (https://bugzilla.redhat.com/attachment.cgi?id=437382)
Patch which makes celt build as DLL on Win32 targets

(In reply to comment #2)
> This package builds both shared and static libraries with native linux builds
> and static libraries only on windows cross builds.  The configure output
> indicates it thinks libtool supports creating dlls.  No idea why it doesn't and
> whenever it is intentional or not.

I just took a quick look at it and here's the culprit:

libtool: link: warning: undefined symbols not allowed in i686-pc-mingw32 shared
libraries

This is a common problem for mingw32 and there's also an easy fix to it (which
doesn't have any side-effects for other platforms). I've attached a patch to
this bugreport which fixes that problem. Feel free to propose it upstream.

With that patch applied, 2 new files show up in the file list:
%{_mingw32_bindir}/libcelt051-0.dll
%{_mingw32_libdir}/libcelt051.dll.a

Now that these files are visible, you can move the static .a library to a
-static subpackage. This is also according to the MinGW packaging guidelines at
http://fedoraproject.org/wiki/Packaging/MinGW#Static_libraries

> The package guidelines about separate -static (and -devel) packages don't apply
> to mingw32-* packacges according to rjones.

He's right about the -devel packages. As all mingw32 packages are only used for
developers, there's no need for -devel subpackages. However, static libraries
need to be put in a -static subpackage as it's recommended to use shared
libraries instead of static libraries.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.