[Bug 661312] Review Request: mingw32-atkmm - MinGW Windows C++ interface for the ATK library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=661312

Kalev Lember <kalev at smartlink.ee> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kalev at smartlink.ee

--- Comment #4 from Kalev Lember <kalev at smartlink.ee> 2010-12-11 10:20:02 EST ---
I have some nitpicking too.

> %{_mingw32_libdir}/atkmm-1.6
> %{_mingw32_libdir}/atkmm-1.6/include
> %{_mingw32_libdir}/atkmm-1.6/include/atkmmconfig.h

These lines cause atkmm-1.6/include/atkmmconfig.h to appear three times and
atkmm-1.6/include/ to appear twice in rpm file lists. If you specify a
directory, rpm will recursively add all the subfolders and files in that
directory. So listing the directory is enough:
%{_mingw32_libdir}/atkmm-1.6/


> %descriptions
> <snip>
> %{_mingw32_debug_package}

There have been issues with that macro getting included verbatim in package
descriptions (Koji used to do that at one point, not sure if it's smarter now)
and a workaround was to use ? to make sure it's expanded to nothing if the
macro isn't defined:
%{?_mingw32_debug_package}


As all the files in this package used to be part of mingw32-gtkmm24, I think
it's one of the very few cases where it's legitimate to use the Conflicts tag
to make sure an old mingw32-gtkmm24 package isn't installed in the system. The
files in the packages will conflict no matter what and the tag is just helping
yum / rpm to see that without having to run the whole transaction check.
Conflicts: mingw32-gtkmm24 < 2.21.1

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.