[Bug 613993] Review Request: mingw32-celt051 - An audio codec for use in low-delay speech and audio communication

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=613993

Erik van Pienbroek <erik-fedora at vanpienbroek.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |erik-fedora at vanpienbroek.nl

--- Comment #1 from Erik van Pienbroek <erik-fedora at vanpienbroek.nl> 2010-07-25 17:33:48 EDT ---
$ rpmlint mingw32-celt051.spec 
mingw32-celt051.spec: W: no-cleaning-of-buildroot %install
mingw32-celt051.spec: W: no-cleaning-of-buildroot %clean
mingw32-celt051.spec: W: no-buildroot-tag
mingw32-celt051.spec: W: no-%clean-section
0 packages and 1 specfiles checked; 0 errors, 4 warnings.

- Please fix the rpmlint warnings mentioned above
- Please use %global instead of %define for all the macros at the top of the
.spec file
- Please add a comment about the purpose of the patch
- Please use 'make %{?_smp_mflags}' instead of just 'make'
- Please use a complete file list instead of %{_mingw32_libdir}/libcelt051* as
the * masks the fact that only a static library is bundled
- Is it correct that this package only provides a static library and no shared
library (DLL)? Shared libraries are preferred in Fedora. If shared libraries
aren't supported by upstream (and upstream doesn't want to support this),
please move all files to a -static subpackage and make the main package require
the -static subpackage

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.