[Bug 688171] i686-pc-mingw32-pkg-config shouldn't unset PKG_CONFIG_PATH

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=688171

--- Comment #6 from Erik van Pienbroek <erik-fedora at vanpienbroek.nl> 2011-04-10 10:54:56 EDT ---
That sounds like a good solution.
Here's a proposed patch:

--- a/macros.mingw32
+++ b/macros.mingw32
@@ -97,9 +97,7 @@ package or when debugging this package.\
   unset x i

 %_mingw32_pkg_config \
-  PKG_CONFIG_LIBDIR="%{_mingw32_libdir}/pkgconfig"; export PKG_CONFIG_LIBDIR;
\
-  unset PKG_CONFIG_PATH; \
-  pkg-config
+  PKG_CONFIG_LIBDIR="%{_mingw32_libdir}/pkgconfig" pkg-config

 %_mingw32_configure %{_mingw32_env} ; \
   __mingw32_topdir=.; if ! test -x configure; then __mingw32_topdir=..; fi;
\\\

The %_mingw32_env macro still has the unset PKG_CONFIG_PATH, but it shouldn't
be called when one calls the script 'mingw32-pkg-config' or
'i686-pc-mingw32-pkg-config'.

Is the patch good enough to commit?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.