[Bug 700815] Review Request: mingw32-gtk3 - MinGW Windows GTK+ library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=700815

Erik van Pienbroek <erik-fedora at vanpienbroek.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |erik-fedora at vanpienbroek.nl
               Flag|                            |fedora-review?

--- Comment #3 from Erik van Pienbroek <erik-fedora at vanpienbroek.nl> 2011-04-29 14:08:29 EDT ---
Looks like you beat me to it in putting this package up for review :)

In your spec you're using a libtool hack to make this package build. In my
attempt I've used a different approach for this issue which is a more generic
solution to this problem and also is upstreamable:
http://svn.openftd.org/svn/fedora_cross/mingw-gtk3/gtk3-win32-libtool-fix.patch
Please consider using this patch

Is the PATH override really necessary to get this package build?

There's one file being placed in %{_mingw32_datadir}/glib-2.0/schemas/. This
folder should be owned by the mingw32-glib2 package but I suspect this ain't
the case at this moment. I'll look into this and push a new update if necessary

The other directory ownerships look good

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.