[Bug 679060] Review Request: mingw32-antlr - MinGW Windows ANTLR C++ run-time library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=679060

Kalev Lember <kalev at smartlink.ee> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |kalev at smartlink.ee
         AssignedTo|nobody at fedoraproject.org    |kalev at smartlink.ee

--- Comment #1 from Kalev Lember <kalev at smartlink.ee> 2011-04-30 08:41:13 EDT ---
Taking for review.

The spec and srpm above are missing all BuildRequires, did you upload the right
files?

The comment "we ship only a static library" just above the %files section is
misleading now that you're also building a dll.

There are some substantial build system improvements in mingw32-antlr.patch,
have you submitted it upstream already?

Not sure how close you want to keep to the native antlr spec file, but if
that's not important, then you can remove BuildRoot definition, the whole
%clean section, and the "rm -rf $RPM_BUILD_ROOT" in the beginning of %install,
as they are no longer needed with current Fedora releases.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.