[Bug 680583] New: routeprot.h has bug related to IP_LOCAL_BINDING

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: routeprot.h has bug related to IP_LOCAL_BINDING

https://bugzilla.redhat.com/show_bug.cgi?id=680583

           Summary: routeprot.h has bug related to IP_LOCAL_BINDING
           Product: Fedora
           Version: 13
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: unspecified
          Priority: unspecified
         Component: mingw32-w32api
        AssignedTo: rjones at redhat.com
        ReportedBy: greearb at candelatech.com
         QAContact: extras-qa at fedoraproject.org
                CC: rjones at redhat.com, kalev at smartlink.ee,
                    fedora-mingw at lists.fedoraproject.org
    Classification: Fedora


Description of problem:

It seems IP_LOCAL_BINDING is defined after it is used.


Version-Release number of selected component (if applicable):

mingw32-w32api-3.13-5.fc13.noarch

How reproducible:

Always

Steps to Reproduce:
1.  Try to compile something that uses routprot.h
2.
3.

Actual results:


In file included from
fea/data_plane/fibconfig/fibconfig_entry_get_iphelper.cc:34:
/usr/i686-pc-mingw32/sys-root/mingw/include/routprot.h:51: error:
'IP_LOCAL_BINDING' does not name a type
scons: ***
[obj/i386-pc-mingw32/fea/data_plane/fibconfig/fibconfig_entry_get_iphelper.o]
Error 1
scons: building terminated because of errors.


Expected results:

Sweet binary goodness.

Additional info:

This seems to fix things:


diff --git a/routprot.h.orig b/routprot.h
index 54fe9ee..2b57df8 100644
--- a/routprot.h.orig
+++ b/routprot.h
@@ -43,6 +43,11 @@ extern "C" {
 #define IPX_PROTOCOL_NLSP 0x00020002
 /*--- Router Management Reference - Router Management Structures */
 #if (_WIN32_WINNT >= 0x0500)
+typedef struct IP_LOCAL_BINDING {
+        DWORD Address;
+        DWORD Mask;
+} IP_LOCAL_BINDING,*PIP_LOCAL_BINDING;
+
 typedef struct IP_ADAPTER_BINDING_INFO {
        ULONG AddressCount;
        DWORD RemoteAddress;
@@ -50,10 +55,7 @@ typedef struct IP_ADAPTER_BINDING_INFO {
        ULONGLONG Speed;
        IP_LOCAL_BINDING Address[];
 } IP_ADAPTER_BINDING_INFO,*PIP_ADAPTER_BINDING_INFO;
-typedef struct IP_LOCAL_BINDING {
-       DWORD Address;
-       DWORD Mask;
-} IP_LOCAL_BINDING,*PIP_LOCAL_BINDING;
+
 typedef struct IPX_ADAPTER_BINDING_INFO {
        ULONG AdapterIndex;
        UCHAR Network[4];

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.