[Bug 754185] Review Request: mingw32-p11-kit - MinGW package for p11-kit

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=754185

--- Comment #2 from Michael Cronenworth <mike at cchtml.com> 2011-11-15 12:48:15 EST ---
(In reply to comment #1)
> Hi Michael,
> 
> Here are some initial review remarks:
> - The following lines can be dropped (because of the automatic RPM 4.9
> dependency magic) :
>   %global _use_internal_dependency_generator 0
>   %global __find_requires %{_mingw32_findrequires}
>   %global __find_provides %{_mingw32_findprovides}

Good to know.

> - Why have you added manual Requires tags for mingw32-gettext and
> mingw32-iconv? Dependencies should normally be handled by the automatic RPM 4.9
> dependency magic so you shouldn't need to provide manual Requires tags here

This is my fault. I was copying files to my Windows host and noted I needed
libintl-8.dll and made a note of it in the spec.

> - Is regenerating the configure script and Makefiles using the
> autotools/libtool really necessary?

Old cruft undoubtedly. Gone.

> - Is the PATH override in the %build section really needed?

Nope.

> - The line 'rm -rf $RPM_BUILD_ROOT' from the %install section, the entire
> %clean section and the %defattr line can be removed as modern RPM doesn't
> require it anymore
> - The folder %{_mingw32_sysconfdir}/pkcs11 is currently un-owned. Please add a
> '%dir %{_mingw32_sysconfdir}/pkcs11' to the %files section

Good catch.

New spec: http://michael.cronenworth.com/RPMS/mingw32-p11-kit.spec
New SRPM:
http://michael.cronenworth.com/RPMS/mingw32-p11-kit-0.9-2.fc15.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.