[Bug 754185] Review Request: mingw-p11-kit - MinGW package for p11-kit
bugzilla at redhat.com
bugzilla at redhat.com
Wed Nov 16 00:55:29 UTC 2011
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=754185
Erik van Pienbroek <erik-fedora at vanpienbroek.nl> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag|fedora-review? |fedora-review+
--- Comment #6 from Erik van Pienbroek <erik-fedora at vanpienbroek.nl> 2011-11-15 19:55:29 EST ---
$ rpmlint mingw-p11-kit.spec
0 packages and 1 specfiles checked; 0 errors, 0 warnings.
$ rpmlint mingw-p11-kit-0.9-4.fc16.src.rpm
mingw-p11-kit.src: W: spelling-error %description -l en_US discoverable ->
discover able, discover-able, irrecoverable
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
$ rpmlint noarch/mingw32-p11-kit-0.9-4.fc16.noarch.rpm
mingw32-p11-kit.noarch: W: spelling-error %description -l en_US discoverable ->
discover able, discover-able, irrecoverable
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
$ rpm --query --requires mingw32-p11-kit
mingw32(kernel32.dll)
mingw32(libintl-8.dll)
mingw32(libp11-kit-0.dll)
mingw32(msvcrt.dll)
mingw32(shell32.dll)
mingw32-filesystem
mingw32-runtime
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(FileDigests) <= 4.6.0-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(PayloadIsXz) <= 5.2-1
$ rpm --query --provides mingw32-p11-kit
mingw32(libp11-kit-0.dll)
mingw32-p11-kit = 0.9-3.fc17
$ rpm --query --fileprovide mingw32-p11-kit
/usr/i686-pc-mingw32/sys-root/mingw/bin/libp11-kit-0.dll
/usr/i686-pc-mingw32/sys-root/mingw/bin/p11-kit.exe
/usr/i686-pc-mingw32/sys-root/mingw/etc/pkcs11
/usr/i686-pc-mingw32/sys-root/mingw/etc/pkcs11/pkcs11.conf.example
/usr/i686-pc-mingw32/sys-root/mingw/include/p11-kit-1
/usr/i686-pc-mingw32/sys-root/mingw/include/p11-kit-1/p11-kit
/usr/i686-pc-mingw32/sys-root/mingw/include/p11-kit-1/p11-kit/p11-kit.h
/usr/i686-pc-mingw32/sys-root/mingw/include/p11-kit-1/p11-kit/pin.h
/usr/i686-pc-mingw32/sys-root/mingw/include/p11-kit-1/p11-kit/pkcs11.h
/usr/i686-pc-mingw32/sys-root/mingw/include/p11-kit-1/p11-kit/uri.h
/usr/i686-pc-mingw32/sys-root/mingw/lib/libp11-kit.dll.a
/usr/i686-pc-mingw32/sys-root/mingw/lib/libp11-kit.la
/usr/i686-pc-mingw32/sys-root/mingw/lib/pkgconfig/p11-kit-1.pc
/usr/share/doc/mingw32-p11-kit-0.9
/usr/share/doc/mingw32-p11-kit-0.9/COPYING
$ curl --silent http://p11-glue.freedesktop.org/releases/p11-kit-0.9.tar.gz |
md5sum
029aa2a3a103e7eb81b4aa731b93539e -
$ md5sum p11-kit-0.9.tar.gz
029aa2a3a103e7eb81b4aa731b93539e p11-kit-0.9.tar.gz
+ OK
! Needs to be looked into
/ Not applicable
* Overridden by MinGW guidelines
[+] Files are installed in /usr/i686-pc-mingw32/sys-root/mingw
[+] BuildRequires: mingw32-filesystem >= xx is in the .spec file
[+] Requires are OK
[+] BuildArch: noarch
[+] No man pages or info files
[+] default strip and objdump commands are overridden with mingw32 specific
ones
[+] rpmlint must be run on every package. The output should be posted in the
review
[+] MUST: The package must be named according to the Package Naming Guidelines
[+] MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption on Package Naming Guidelines
[+] MUST: The package must meet the Packaging Guidelines
[+] MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines .
[+] MUST: The License field in the package spec file must match the actual
license.
[+] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL.
[+] MUST: The package must successfully compile and build into binary rpms on
at least one supported architecture.
[/] MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch.
[+] MUST: All build dependencies must be listed in BuildRequires, except for
any that are listed in the exceptions section of the Packaging Guidelines;
inclusion of those as BuildRequires is optional.
[/] MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
[/] MUST: Every binary RPM package which stores shared library files (not just
symlinks) in any of the dynamic linker's default paths, must call ldconfig in
%post and %postun.
[/] MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review, along with the rationalization for
relocation of that specific package.
[+] MUST: A package must own all directories that it creates.
[+] MUST: A package must not contain any duplicate files in the %files listing.
[+] MUST: Permissions on files must be set properly.
[+] MUST: Each package must consistently use macros, as described in the macros
section of Packaging Guidelines.
[+] MUST: The package must contain code, or permissable content.
[/] MUST: Large documentation files should go in a -doc subpackage.
[+] MUST: If a package includes something as %doc, it must not affect the
runtime of the application.
[*] MUST: Header files must be in a -devel package.
[/] MUST: Static libraries must be in a -static package.
[+] MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'
(for directory ownership and usability).
[/] MUST: If a package contains library files with a suffix (e.g.
libfoo.so.1.1), then library files that end in .so (without suffix) must go in
a -devel package.
[/] MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency: Requires: %{name} =
%{version}-%{release}
[*] MUST: Packages must NOT contain any .la libtool archives, these should be
removed in the spec.
[/] MUST: Packages containing GUI applications must include a %{name}.desktop
file, and that file must be properly installed with desktop-file-install in the
%install section.
[+] MUST: Packages must not own files or directories already owned by other
packages.
[+] MUST: All filenames in rpm packages must be valid UTF-8.
[/] SHOULD: If the source package does not include license text(s) as a
separate file from upstream, the packager SHOULD query upstream to include it.
[/] SHOULD: The description and summary sections in the package spec file
should contain translations for supported Non-English languages, if available.
[+] SHOULD: The reviewer should test that the package builds in mock. See
MockTricks for details on how to do this.
[+] SHOULD: The package should compile and build into binary rpms on all
supported architectures.
[+] SHOULD: The reviewer should test that the package functions as described. A
package should not segfault instead of running, for example.
[/] SHOULD: If scriptlets are used, those scriptlets must be sane. This is
vague, and left up to the reviewers judgement to determine sanity.
[/] SHOULD: Usually, subpackages other than devel should require the base
package using a fully versioned dependency.
[*] SHOULD: The placement of pkgconfig(.pc) files depends on their usecase, and
this is usually for development purposes, so should be placed in a -devel pkg.
[/] SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin,
/usr/bin, or /usr/sbin consider requiring the package which provides the file
instead of the file itself.
You might want enable verbose output during the build by adding the argument
"V=1" to the "make" command.
This makes it easier to investigate any future build issues you may encounter.
As we're also making preparations for the introduction of the mingw-w64
toolchain in Fedora
(currently pending on legal approval) I also tested this package with the
mingw-w64 toolchain.
A small patch is needed to get this package built with the mingw-w64 toolchain.
You may already send it upstream so they can incorporate it in their next
version.
It shouldn't do any harm to already include it in this package for the time
being (to make
the transition to mingw-w64 easier), but I'll leave that up to you to decide.
The patch can be found at:
http://svn.openftd.org/svn/fedora_cross/mingw-p11-kit/p11-kit-mingw-w64-compatibility.patch
====================================================
The package mingw-p11-kit is APPROVED by epienbro
====================================================
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the mingw
mailing list