[Bug 812573] Review Request: mingw-gstreamer-plugins-good - Cross compiled GStreamer plug-ins good

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=812573

Erik van Pienbroek <erik-fedora at vanpienbroek.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |erik-fedora at vanpienbroek.nl
         AssignedTo|nobody at fedoraproject.org    |erik-fedora at vanpienbroek.nl

--- Comment #1 from Erik van Pienbroek <erik-fedora at vanpienbroek.nl> 2012-04-15 05:36:23 EDT ---
Taking for review

The following lines are obsolete and can be removed:
%global mingw_build_win32 1
%global mingw_build_win64 1

Please bump the BR: mingw32-filesystem and mingw64-filesystem to >= 95

The BR: pkgconfig can be removed as it's already part of the default build root
in Fedora

The BR: mingw32-libjpeg and mingw64-libjpeg can be changed to
mingw32-libjpeg-turbo and mingw64-libjpeg-turbo as there are no mingw32-libjpeg
or mingw64-libjpeg packages in Fedora any more (they are replaced by
mingw-libjpeg-turbo)

The BR: mingw32-orc and mingw64-orc can't be satisfied at the moment as the
package mingw-orc isn't available in Fedora at the moment, so that package
needs to be put up for review first

The %{mingw_pkg_name} macro is currently obsolete. Please use the full package
name in the places where this macro is used

The Summary: %{summary} tags (in the subpackages) don't give the expected
result. Please don't use the %{summary} tag

The quotes used by the various arguments in the %mingw_configure aren't needed
any more and can be removed. This %mingw_configure line can also be split among
multiple lines to improve readability

Please use the %mingw_find_lang macro instead of the %find_lang macro. This
macro generates two file lists named mingw32-gstreamer-plugins-good.lang and
mingw64-gstreamer-plugins-good.lang with translations for mingw32 and mingw64
packages, so don't forget to also update the %files tags

Why are the files in the -static subpackages commented out? Right now the
-static subpackages are empty packages

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.