[Bug 787878] Review Request: mingw32-icu - MinGW compilation of International Components for Unicode Tools

bugzilla at redhat.com bugzilla at redhat.com
Tue Feb 7 21:58:00 UTC 2012


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=787878

--- Comment #3 from Michael Cronenworth <mike at cchtml.com> 2012-02-07 16:58:00 EST ---
Hey PaweĊ‚ nice bug number. :)

This is my unofficial review:
-Bug subject needs to be:
Review Request: mingw-icu - MinGW compilation of International Components for
Unicode Tools
-Change mingw32-filesystem to >= 68
-Change your %defines at the top to use %globals such as:
%global __strip %{_mingw32_strip}
%global __objdump %{_mingw32_objdump}
%define __debug_install_post %{_mingw32_debug_install_post}

Everything else looks pretty good, but I might have missed something.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.


More information about the mingw mailing list