[Bug 820729] Review Request: mingw-cximage - MinGW Windows CxImage manipulation library

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=820729

--- Comment #2 from Marc-Andre Lureau <marcandre.lureau at redhat.com> ---
(In reply to comment #1)
> Taking for review
> 
> - The BuildRoot tag, the entire %clean section and the %defattr tags in the
> %files sections aren't needed any more with modern RPM and can be removed
> - Please remove the use of the %{summary} macro and give the -static
> subpackages a more proper summary

thanks, done

> The unpack procedure in the %prep section is a bit odd, but I guess this is
> caused by the fact that current RPM doesn't support 7zip archives yet.

Yes, I know cfergeau at redhat.com has been working on a rpm patch.

> The %mingw_debug_install_post call in the %install section shouldn't be
> necessary. As it already contains a FIXME comment I'll try to investigate
> this issue here

As I say in the spec, I have no idea why we need to call it ourself, I would be
glad to get some help, as I don't know how to debug this one.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.fedoraproject.org/pipermail/mingw/attachments/20120522/85135a4f/attachment-0001.html>