[Bug 851292] Review Request: mingw-poppler: MinGW PDF rendering library

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=851292

greg.hellings at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |greg.hellings at gmail.com

--- Comment #1 from greg.hellings at gmail.com ---
You're now a bugfix release behind upstream. They appear to have released
0.20.3 earlier last month. You might want to grab that and see if they've
upstreamed any of your patches.

Is there a reason you disabled zlib? It should be available in Fedora for
building. Is support in Poppler sketchy under the mingw build when you enable
zlib?

You should use the %mingw_make_install macro directly instead of adding the
'install' argument to your build.

You can remove the lines that begin with %defattr in the %files sections.

rpmlint gives the following output:
$ for r in $(find . -name '*.rpm'); do echo $r; rpmlint $r; done
./mingw-poppler-0.20.2-1.fc17.src.rpm
mingw-poppler.src: W: spelling-error %description -l en_US xpdf -> expend
mingw-poppler.src: W: patch-not-applied Patch1:
poppler-0.12.4-annot-appearance.patch
1 packages and 0 specfiles checked; 0 errors, 2 warnings.
./mingw-poppler-0.20.2-1.fc19.src.rpm
mingw-poppler.src: W: spelling-error %description -l en_US xpdf -> expend
mingw-poppler.src: W: patch-not-applied Patch1:
poppler-0.12.4-annot-appearance.patch
1 packages and 0 specfiles checked; 0 errors, 2 warnings.
./noarch/mingw32-poppler-static-0.20.2-1.fc19.noarch.rpm
mingw32-poppler-static.noarch: W: no-documentation
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
./noarch/mingw32-poppler-debuginfo-0.20.2-1.fc19.noarch.rpm
mingw32-poppler-debuginfo.noarch: E: debuginfo-without-sources
1 packages and 0 specfiles checked; 1 errors, 0 warnings.
./noarch/mingw32-poppler-0.20.2-1.fc19.noarch.rpm
mingw32-poppler.noarch: W: spelling-error %description -l en_US xpdf -> expend
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
./noarch/mingw64-poppler-0.20.2-1.fc19.noarch.rpm
mingw64-poppler.noarch: W: spelling-error %description -l en_US xpdf -> expend
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
./noarch/mingw64-poppler-debuginfo-0.20.2-1.fc19.noarch.rpm
mingw64-poppler-debuginfo.noarch: E: debuginfo-without-sources
1 packages and 0 specfiles checked; 1 errors, 0 warnings.
./noarch/mingw64-poppler-static-0.20.2-1.fc19.noarch.rpm
mingw64-poppler-static.noarch: W: no-documentation
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

-- 
You are receiving this mail because:
You are on the CC list for the bug.