[Bug 833623] Review Request: mingw-nettle - Cross-compiled low level crytopgraphic library
bugzilla at redhat.com
bugzilla at redhat.com
Fri Sep 21 13:54:05 UTC 2012
https://bugzilla.redhat.com/show_bug.cgi?id=833623
Kalev Lember <kalevlember at gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |
Flags| |fedora-review+
--- Comment #5 from Kalev Lember <kalevlember at gmail.com> ---
Fedora review of mingw-nettle-2.4-2.fc17.src.rpm 2012-09-21
+ OK
! needs attention
rpmlint output:
$ rpmlint mingw-nettle-2.4-2.fc18.src.rpm \
mingw32-nettle-2.4-2.fc18.noarch.rpm \
mingw64-nettle-2.4-2.fc18.noarch.rpm \
mingw32-nettle-debuginfo-2.4-2.fc18.noarch.rpm \
mingw64-nettle-debuginfo-2.4-2.fc18.noarch.rpm
mingw-nettle.src: W: spelling-error Summary(en_US) crytopgraphic ->
topographic, cartographic, photographic
mingw-nettle.src: W: spelling-error %description -l en_US cryptographic ->
cryptography, cryptographer, crystallographic
mingw-nettle.src: W: spelling-error %description -l en_US crypto -> crypt,
crypts, crypt o
mingw-nettle.src: W: spelling-error %description -l en_US toolkits -> toolkit,
tool kits, tool-kits
mingw32-nettle.noarch: W: spelling-error Summary(en_US) crytopgraphic ->
topographic, cartographic, photographic
mingw32-nettle.noarch: W: spelling-error %description -l en_US cryptographic ->
cryptography, cryptographer, crystallographic
mingw32-nettle.noarch: W: spelling-error %description -l en_US crypto -> crypt,
crypts, crypt o
mingw32-nettle.noarch: W: spelling-error %description -l en_US toolkits ->
toolkit, tool kits, tool-kits
mingw32-nettle.noarch: E: incorrect-fsf-address
/usr/i686-w64-mingw32/sys-root/mingw/include/nettle/arctwo.h
mingw32-nettle.noarch: E: incorrect-fsf-address
/usr/i686-w64-mingw32/sys-root/mingw/include/nettle/realloc.h
mingw32-nettle.noarch: E: incorrect-fsf-address
/usr/i686-w64-mingw32/sys-root/mingw/include/nettle/rsa-compat.h
mingw32-nettle.noarch: E: incorrect-fsf-address
/usr/i686-w64-mingw32/sys-root/mingw/include/nettle/blowfish.h
mingw32-nettle.noarch: E: incorrect-fsf-address
/usr/i686-w64-mingw32/sys-root/mingw/include/nettle/ctr.h
mingw32-nettle.noarch: E: incorrect-fsf-address
/usr/i686-w64-mingw32/sys-root/mingw/include/nettle/buffer.h
mingw32-nettle.noarch: E: incorrect-fsf-address
/usr/i686-w64-mingw32/sys-root/mingw/include/nettle/ripemd160.h
mingw32-nettle.noarch: E: incorrect-fsf-address
/usr/i686-w64-mingw32/sys-root/mingw/include/nettle/arcfour.h
mingw32-nettle.noarch: E: incorrect-fsf-address
/usr/i686-w64-mingw32/sys-root/mingw/include/nettle/nettle-meta.h
mingw32-nettle.noarch: E: incorrect-fsf-address
/usr/i686-w64-mingw32/sys-root/mingw/include/nettle/dsa.h
mingw32-nettle.noarch: E: incorrect-fsf-address
/usr/i686-w64-mingw32/sys-root/mingw/include/nettle/hmac.h
mingw32-nettle.noarch: E: incorrect-fsf-address
/usr/i686-w64-mingw32/sys-root/mingw/include/nettle/aes.h
mingw32-nettle.noarch: W: file-not-utf8
/usr/share/doc/mingw32-nettle-2.4/README
mingw32-nettle.noarch: E: incorrect-fsf-address
/usr/i686-w64-mingw32/sys-root/mingw/include/nettle/sha.h
mingw32-nettle.noarch: E: incorrect-fsf-address
/usr/i686-w64-mingw32/sys-root/mingw/include/nettle/md2.h
mingw32-nettle.noarch: E: incorrect-fsf-address
/usr/i686-w64-mingw32/sys-root/mingw/include/nettle/cast128.h
mingw32-nettle.noarch: E: incorrect-fsf-address
/usr/i686-w64-mingw32/sys-root/mingw/include/nettle/serpent.h
mingw32-nettle.noarch: E: incorrect-fsf-address
/usr/i686-w64-mingw32/sys-root/mingw/include/nettle/md4.h
mingw32-nettle.noarch: E: incorrect-fsf-address
/usr/i686-w64-mingw32/sys-root/mingw/include/nettle/base16.h
mingw32-nettle.noarch: E: incorrect-fsf-address
/usr/i686-w64-mingw32/sys-root/mingw/include/nettle/md5-compat.h
mingw32-nettle.noarch: E: incorrect-fsf-address
/usr/i686-w64-mingw32/sys-root/mingw/include/nettle/md5.h
mingw32-nettle.noarch: E: incorrect-fsf-address
/usr/i686-w64-mingw32/sys-root/mingw/include/nettle/macros.h
mingw32-nettle.noarch: E: incorrect-fsf-address
/usr/i686-w64-mingw32/sys-root/mingw/include/nettle/des.h
mingw32-nettle.noarch: E: incorrect-fsf-address
/usr/i686-w64-mingw32/sys-root/mingw/include/nettle/bignum.h
mingw32-nettle.noarch: E: incorrect-fsf-address
/usr/i686-w64-mingw32/sys-root/mingw/include/nettle/cbc.h
mingw32-nettle.noarch: E: incorrect-fsf-address
/usr/i686-w64-mingw32/sys-root/mingw/include/nettle/rsa.h
mingw32-nettle.noarch: E: incorrect-fsf-address
/usr/i686-w64-mingw32/sys-root/mingw/include/nettle/pgp.h
mingw32-nettle.noarch: E: incorrect-fsf-address
/usr/i686-w64-mingw32/sys-root/mingw/include/nettle/asn1.h
mingw32-nettle.noarch: E: incorrect-fsf-address
/usr/i686-w64-mingw32/sys-root/mingw/include/nettle/yarrow.h
mingw32-nettle.noarch: E: incorrect-fsf-address
/usr/i686-w64-mingw32/sys-root/mingw/include/nettle/twofish.h
mingw32-nettle.noarch: E: incorrect-fsf-address
/usr/i686-w64-mingw32/sys-root/mingw/include/nettle/nettle-types.h
mingw32-nettle.noarch: E: incorrect-fsf-address
/usr/i686-w64-mingw32/sys-root/mingw/include/nettle/base64.h
mingw32-nettle.noarch: E: incorrect-fsf-address
/usr/i686-w64-mingw32/sys-root/mingw/include/nettle/sexp.h
mingw32-nettle.noarch: E: incorrect-fsf-address
/usr/i686-w64-mingw32/sys-root/mingw/include/nettle/knuth-lfib.h
mingw32-nettle.noarch: E: incorrect-fsf-address
/usr/i686-w64-mingw32/sys-root/mingw/include/nettle/des-compat.h
mingw32-nettle.noarch: E: incorrect-fsf-address
/usr/i686-w64-mingw32/sys-root/mingw/include/nettle/pkcs1.h
mingw64-nettle.noarch: W: spelling-error Summary(en_US) crytopgraphic ->
topographic, cartographic, photographic
mingw64-nettle.noarch: W: spelling-error %description -l en_US cryptographic ->
cryptography, cryptographer, crystallographic
mingw64-nettle.noarch: W: spelling-error %description -l en_US crypto -> crypt,
crypts, crypt o
mingw64-nettle.noarch: W: spelling-error %description -l en_US toolkits ->
toolkit, tool kits, tool-kits
mingw64-nettle.noarch: E: incorrect-fsf-address
/usr/x86_64-w64-mingw32/sys-root/mingw/include/nettle/dsa.h
mingw64-nettle.noarch: E: incorrect-fsf-address
/usr/x86_64-w64-mingw32/sys-root/mingw/include/nettle/arcfour.h
mingw64-nettle.noarch: E: incorrect-fsf-address
/usr/x86_64-w64-mingw32/sys-root/mingw/include/nettle/md2.h
mingw64-nettle.noarch: E: incorrect-fsf-address
/usr/x86_64-w64-mingw32/sys-root/mingw/include/nettle/arctwo.h
mingw64-nettle.noarch: E: incorrect-fsf-address
/usr/x86_64-w64-mingw32/sys-root/mingw/include/nettle/ctr.h
mingw64-nettle.noarch: E: incorrect-fsf-address
/usr/x86_64-w64-mingw32/sys-root/mingw/include/nettle/serpent.h
mingw64-nettle.noarch: E: incorrect-fsf-address
/usr/x86_64-w64-mingw32/sys-root/mingw/include/nettle/bignum.h
mingw64-nettle.noarch: E: incorrect-fsf-address
/usr/x86_64-w64-mingw32/sys-root/mingw/include/nettle/cbc.h
mingw64-nettle.noarch: E: incorrect-fsf-address
/usr/x86_64-w64-mingw32/sys-root/mingw/include/nettle/yarrow.h
mingw64-nettle.noarch: E: incorrect-fsf-address
/usr/x86_64-w64-mingw32/sys-root/mingw/include/nettle/pkcs1.h
mingw64-nettle.noarch: E: incorrect-fsf-address
/usr/x86_64-w64-mingw32/sys-root/mingw/include/nettle/macros.h
mingw64-nettle.noarch: E: incorrect-fsf-address
/usr/x86_64-w64-mingw32/sys-root/mingw/include/nettle/asn1.h
mingw64-nettle.noarch: E: incorrect-fsf-address
/usr/x86_64-w64-mingw32/sys-root/mingw/include/nettle/rsa-compat.h
mingw64-nettle.noarch: E: incorrect-fsf-address
/usr/x86_64-w64-mingw32/sys-root/mingw/include/nettle/blowfish.h
mingw64-nettle.noarch: E: incorrect-fsf-address
/usr/x86_64-w64-mingw32/sys-root/mingw/include/nettle/sha.h
mingw64-nettle.noarch: E: incorrect-fsf-address
/usr/x86_64-w64-mingw32/sys-root/mingw/include/nettle/cast128.h
mingw64-nettle.noarch: E: incorrect-fsf-address
/usr/x86_64-w64-mingw32/sys-root/mingw/include/nettle/aes.h
mingw64-nettle.noarch: E: incorrect-fsf-address
/usr/x86_64-w64-mingw32/sys-root/mingw/include/nettle/base16.h
mingw64-nettle.noarch: E: incorrect-fsf-address
/usr/x86_64-w64-mingw32/sys-root/mingw/include/nettle/buffer.h
mingw64-nettle.noarch: E: incorrect-fsf-address
/usr/x86_64-w64-mingw32/sys-root/mingw/include/nettle/sexp.h
mingw64-nettle.noarch: E: incorrect-fsf-address
/usr/x86_64-w64-mingw32/sys-root/mingw/include/nettle/twofish.h
mingw64-nettle.noarch: E: incorrect-fsf-address
/usr/x86_64-w64-mingw32/sys-root/mingw/include/nettle/knuth-lfib.h
mingw64-nettle.noarch: E: incorrect-fsf-address
/usr/x86_64-w64-mingw32/sys-root/mingw/include/nettle/des.h
mingw64-nettle.noarch: E: incorrect-fsf-address
/usr/x86_64-w64-mingw32/sys-root/mingw/include/nettle/md5-compat.h
mingw64-nettle.noarch: W: file-not-utf8
/usr/share/doc/mingw64-nettle-2.4/README
mingw64-nettle.noarch: E: incorrect-fsf-address
/usr/x86_64-w64-mingw32/sys-root/mingw/include/nettle/ripemd160.h
mingw64-nettle.noarch: E: incorrect-fsf-address
/usr/x86_64-w64-mingw32/sys-root/mingw/include/nettle/des-compat.h
mingw64-nettle.noarch: E: incorrect-fsf-address
/usr/x86_64-w64-mingw32/sys-root/mingw/include/nettle/pgp.h
mingw64-nettle.noarch: E: incorrect-fsf-address
/usr/x86_64-w64-mingw32/sys-root/mingw/include/nettle/rsa.h
mingw64-nettle.noarch: E: incorrect-fsf-address
/usr/x86_64-w64-mingw32/sys-root/mingw/include/nettle/realloc.h
mingw64-nettle.noarch: E: incorrect-fsf-address
/usr/x86_64-w64-mingw32/sys-root/mingw/include/nettle/nettle-types.h
mingw64-nettle.noarch: E: incorrect-fsf-address
/usr/x86_64-w64-mingw32/sys-root/mingw/include/nettle/nettle-meta.h
mingw64-nettle.noarch: E: incorrect-fsf-address
/usr/x86_64-w64-mingw32/sys-root/mingw/include/nettle/hmac.h
mingw64-nettle.noarch: E: incorrect-fsf-address
/usr/x86_64-w64-mingw32/sys-root/mingw/include/nettle/md4.h
mingw64-nettle.noarch: E: incorrect-fsf-address
/usr/x86_64-w64-mingw32/sys-root/mingw/include/nettle/md5.h
mingw64-nettle.noarch: E: incorrect-fsf-address
/usr/x86_64-w64-mingw32/sys-root/mingw/include/nettle/base64.h
mingw32-nettle-debuginfo.noarch: E: debuginfo-without-sources
mingw64-nettle-debuginfo.noarch: E: debuginfo-without-sources
5 packages and 0 specfiles checked; 72 errors, 14 warnings.
The only rpmlint warning I would address are the two 'file-not-utf8' warnings
about the README file. The rest of the documentation is already removed from
the rpm, so it might make sense to also get rid of the README files.
Other rpmlint warnings/errors are harmless and can be ignored.
+ The package is named according to Fedora MinGW packaging guidelines
+ The spec file name matches the base package name.
+ The package meets the Packaging Guidelines
+ The package is licensed with a Fedora approved license and meets the
Licensing Guidelines.
+ The license field in the spec file matches the actual license
+ The stated license is the same as the one for the corresponding
native Fedora package
+ The package contains the license file (COPYING.lib)
+ Spec file is written in American English
+ Spec file is legible
+ Upstream sources match sources in the srpm. md5sum:
450be8c4886d46c09f49f568ad6fa013 nettle-2.4.tar.gz
450be8c4886d46c09f49f568ad6fa013 Download/nettle-2.4.tar.gz
+ The package builds in koji
n/a ExcludeArch bugs filed
+ BuildRequires look sane
n/a locale handling
n/a ldconfig in %post and %postun
+ Package does not bundle copies of system libraries
n/a Package isn't relocatable
+ Package owns all directories it creates
+ No duplicate files in %files
+ Permissions are properly set
+ Consistent use of macros
+ The package must contain code or permissible content
n/a Large documentation files should go in -doc subpackage
+ Files marked %doc should not affect package
n/a Header files should be in -devel
Not applicable to MinGW packages.
n/a Static libraries should be in -static
n/a Library files that end in .so must go in a -devel package
n/a -devel must require the fully versioned base
+ Packages must not contain libtool .la files
n/a Packages containing GUI apps must include %{name}.desktop file
+ Directory ownership sane
+ Filenames are valid UTF-8
Summary
-------
Looks nice and clean. Besides the 'file-not-utf8' warning mentioned above, I
have two small nitpicks, which are of course not review blockers:
- Might be nice to start Summary with 'MinGW ...', like most of the other
MinGW library packages have, just to make it visually more consistent
when listing mingw packages.
- We are trying to move away from %mingw_make_install and just use the
%mingw_make macro with an 'install' argument. Would be nice to use
'%mingw_make' here as well.
Feel free to address these before importing the package into SCM.
APPROVED
--
You are receiving this mail because:
You are on the CC list for the bug.
More information about the mingw
mailing list