[Bug 851820] Review Request: mingw-eigen3 - MinGW lightweight C++ template library for vector and matrix math

[bugzilla at redhat.com]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=851820

--- Comment #3 from Sandro Mani <manisandro at gmail.com> ---
I've uploaded a proposed SPEC+SRPM which takes into consideration the below
remarks here:
SPEC: http://smani.fedorapeople.org/mingw-eigen3.spec
SRPM: http://smani.fedorapeople.org/mingw-eigen3-3.1.2-1.fc19.src.rpm

Needs work:
- Version 3.1.2 is out (also reported for the eigen3 package, see bug #917145)
- Now mainly MPL2 licensed, plus portions BSD and GPL2 licensed
   * Change License to "MPL2 and LGPLv2+ and BSD"
   * Adjust %doc accordingly
- Unused BuildRequires (documentation is not built, and due to the unit tests
which cannot be run in a cross-compile environment)
- BuildRoot is not necessary anymore
   * See http://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag
- %clean section not necessary anymore
   * See http://fedoraproject.org/wiki/Packaging:Guidelines#.25clean
- %defattr is not necessary anymore
   * See http://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions
- Package does not build, since BuildRequires references non-existing packages
   * Since the mingw package only contains the headers 
- Running Eigen's unit tests does not work in a cross-compiling environment
  (since the resulting binaries are windows ones and cannot be executed)
   * You either need to preset some variables to make cmake ignore the fact
that
     it cannot run binaries (see the TryRunResults.cmake in the SRPM I linked
     above), and a hack is also necessary for it to stop throwing an error
     because it could not determine the windows OS version. All this simply to 
     get cmake to do the initial configuration. cmake is actually only useful 
     for generating the pkgconfig file.
   * Or you could choose to not use cmake at all, and instead simply copy the
     headers and generate the pkg-config with sed (possibly a little less
     elegant? Though the first approach is also ugly enough :) )
- You don't need %{?mingw_debug_package}, since there is no debug info to be
  provided (only headers are installed)

Unsure:
- Is there a particular reason you move the pc files from share/pkgconfig to
lib/pkgconfig? AFAIK both are ok (pkgconfig works also in share/pkgconfig)
- Should you Require: pkgconfig ? some packages do, i.e. glew

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=EoABjLZqbs&a=cc_unsubscribe