[Bug 858084] Review Request: mingw-qt5-qtwebkit - Qt5 for Windows - QtWebKit component

[bugzilla at redhat.com]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=858084

--- Comment #5 from Erik van Pienbroek <erik-fedora at vanpienbroek.nl> ---
On second thought, mt19937ar.c isn't being used during compilation (for both
Linux and Windows):

[erik at erik qtwebkit-opensource-src-5.0.2]$ grep -Hr mt19937ar *
ChangeLog-2012-05-22:        Move wince/mt19937ar.c to ThirdParty and make it a
policy choice
ChangeLog-2012-05-22:        * Source/ThirdParty/mt19937ar.c: Copied from
Source/JavaScriptCore/wtf/wince/mt19937ar.c.
Source/WTF/WTF.pro:    # for mt19937ar.c
Source/WTF/wtf/RandomNumber.cpp:#include "mt19937ar.c"
Source/WTF/ChangeLog:        Also include path for mt19937ar.c
Source/JavaScriptCore/ChangeLog-2011-02-16:        Move wince/mt19937ar.c to
ThirdParty and make it a policy choice
Source/JavaScriptCore/ChangeLog-2010-05-24:        * wtf/wince/mt19937ar.c:
Added.

--> mt19937ar.c is only used during the compilation of
Source/WTF/wtf/RandomNumber.cpp, taking a closer look at this file:

#if USE(MERSENNE_TWISTER_19937)
extern "C" {
#include "mt19937ar.c"
}
#endif

--> mt19937ar.c is only used when MERSENNE_TWISTER_19937 is set, searching for
places where it is set:

[erik at erik qtwebkit-opensource-src-5.0.2]$ grep -Hr MERSENNE_TWISTER_19937 *
Source/WTF/wtf/RandomNumberSeed.h:#if USE(MERSENNE_TWISTER_19937)
Source/WTF/wtf/RandomNumberSeed.h:#if USE(MERSENNE_TWISTER_19937)
Source/WTF/wtf/RandomNumber.cpp:#if USE(MERSENNE_TWISTER_19937)
Source/WTF/wtf/RandomNumber.cpp:#if USE(MERSENNE_TWISTER_19937)
Source/WTF/wtf/Platform.h:#define WTF_USE_MERSENNE_TWISTER_19937 1
Source/WTF/wtf/Platform.h:#define WTF_USE_MERSENNE_TWISTER_19937 1
Source/WebKit/blackberry/WebCoreSupport/AboutDataUseFeatures.in:MERSENNE_TWISTER_19937
Source/JavaScriptCore/ChangeLog-2011-02-16:        Modify RandomNumberSeed.h to
use USE(MERSENNE_TWISTER_19937)
Source/JavaScriptCore/ChangeLog-2011-02-16:        * wtf/Platform.h: Defined
WTF_USE_MERSENNE_TWISTER_19937 when
Source/JavaScriptCore/ChangeLog-2011-02-16:        (WTF::randomNumber):
Substituted USE(MERSENNE_TWISTER_19937) for OS(WINCE).

--> The flag is only set in Source/WTF/wtf/Platform.h, taking a closer look at
this:

#if PLATFORM(BLACKBERRY)
#define WTF_USE_MERSENNE_TWISTER_19937 1
<snip>
#endif

..

#if OS(WINCE)
#define WTF_USE_MERSENNE_TWISTER_19937 1
#endif

--> Conclusion: the code from mt19937ar.c is only being used for the BlackBerry
and WindowsCE targets

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=cD5r1wFGQ8&a=cc_unsubscribe