[Bug 200348] Review Request: libgadu - Gadu-Gadu protocol support library

bugzilla at redhat.com bugzilla at redhat.com
Thu Aug 3 18:23:34 UTC 2006


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libgadu - Gadu-Gadu protocol support library


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200348





------- Additional Comments From gajownik at gmail.com  2006-08-03 14:14 EST -------
I'm not a sponsor so this review is informal:

* You should pass option --disable-bind or --enable-bind to configure script.
Without it rebuild of a package in different build environment can lead to
different dependencies/features of final RPM.
* Debian package adds option --enable-pthread. IMHO it's worth to enable it, too.
* Add CFLAGS_LIBGADU="$CFLAGS" to configure script. Right now package is being
built without gcc optimizations/security features.
* Mark proper files as %lang(pl). Please see
http://www.redhat.com/archives/fedora-extras-list/2006-August/msg00090.html for
more information
* Replace %files with %%files. Hint: you should run rpmlint on srpms, too:

[rpm-build at X RPMS]$ rpmlint ../SRPMS/libgadu-20060726-2.src.rpm
W: libgadu macro-in-%changelog files
[rpm-build at X RPMS]$

I have changed $RPM_BUILD_ROOT to %{buildroot} because it's shorter. You can
revert this change if you don't like it.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the package-review mailing list