[Bug 187610] Review Request: crm114 - CRM114 Bayesian Spam Detector

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: crm114 - CRM114 Bayesian Spam Detector


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=187610





------- Additional Comments From paul at all-the-johnsons.co.uk  2006-08-14 17:26 EST -------
Release: %{rel}.%{cvsver} - you need the %{?dist} tag adding

%build
%{__make} %{?_smp_mflags} INSTALL_DIR=$RPM_BUILD_ROOT%{_bindir}
CFLAGS="$RPM_OPT_FLAGS"

does the install dir need to be here (and the CFLAGS)?

install -d $RPM_BUILD_ROOT{%{_bindir},%{_datadir}/%{name}}

the make install should create these directories for you. If they don't, mkdir
-p is the way to go.

%{__make} BINDIR=${RPM_BUILD_ROOT}%{_bindir} install

Isn't make DEST_DIR=%{buildroot} install more usual?

%{_datadir}/%{name}/*.crm

This just needs to be %{_datadir}/%{name}/

The binary files should already be 755, so the %defattr before them shouldn't be
required.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.