[Bug 199168] Review Request: CGAL

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: CGAL


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199168





------- Additional Comments From laurent.rineau__fedora_extras at normalesup.org  2006-08-16 03:11 EST -------
Actions(In reply to comment #7)
> I must be missing something very basic:
> 
> # rpm -qlp CGAL-3.2.1-14.i386.rpm
> /usr/share/doc/CGAL-3.2.1
> /usr/share/doc/CGAL-3.2.1/LICENSE
> /usr/share/doc/CGAL-3.2.1/LICENSE.FREE_USE
> /usr/share/doc/CGAL-3.2.1/LICENSE.LGPL
> /usr/share/doc/CGAL-3.2.1/LICENSE.QPL
> /usr/share/doc/CGAL-3.2.1/README.Fedora
> 
> This doesn't look like a reasonable packaging to me.
> 
> Also:
> 
> # rpmlint CGAL-*3.2.1-14.i386.rpm
> E: CGAL devel-dependency CGAL-devel
> E: CGAL no-binary
> W: CGAL-devel no-dependency-on CGAL

CGAL is a meta-package that requires CGAL-libs, CGAL-devel, and CGAL-sources. 
The reason is that the CGAL users community is used to get CGAL as a whole.

> E: CGAL-devel file-in-usr-marked-as-conffile /usr/share/CGAL/make/makefile
> E: CGAL-devel script-without-shellbang /etc/profile.d/cgal.sh
> E: CGAL-devel script-without-shellbang /etc/profile.d/cgal.csh

As far as I know, these rpmlint errors should be ignored.

(In reply to comment #8)
> Further issues:
> 
> - The *-devel package ships /usr/include/CORE
> IMO, this directory name is too general.

CGAL-3.2.1 ships CORE-1.7, http://www.cs.nyu.edu/exact/core_pages/intro.html
This directory is from CORE.

> - Static libs:
> /usr/lib/libCGALQt.a
> /usr/lib/libcore++.a

upstream libCGALQt is static only, as indicated in comment #1, as well as 
upstream libcore++. I know that static libraries should be avoided "as far as 
possible", in Fedora. Is the upstream devs choice a sufficient reason?

> - A more general design problem:
> Some headers in /usr/include/CGAL hard-code configuration-time detected
> * system features, e.g. the version of zlib and Qt
> 
> * compiler characteristics, e.g. endianness.

Yes, it should only be /usr/include/CGAL/compiler_config.h. Is it a blocker?


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.