[Bug 199168] Review Request: CGAL

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: CGAL


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199168





------- Additional Comments From laurent.rineau__fedora_extras at normalesup.org  2006-08-17 07:48 EST -------
(In reply to comment #16)
> > > > > E: CGAL-devel script-without-shellbang /etc/profile.d/cgal.sh
> > > > > E: CGAL-devel script-without-shellbang /etc/profile.d/cgal.csh
> > These files are sourced and not
> > executed. 
> Then they should NOT be executable => chmod -x

Agreed. It is patch in my spec file. Maybe should someone fill bugs about 
other packages that share that issue. I do not know how to use XML-XPC.
  >> TODO-latter

(In reply to comment #8)
> - A more general design problem:
> Some headers in /usr/include/CGAL hard-code configuration-time detected
> * system features, e.g. the version of zlib and Qt

The CGAL_FOOBAR_VERSION macros are not used in CGAL, actually. They are here 
only for internal uses (to be displayed by the testsuite). I can prune that 
from the package.
 
> * compiler characteristics, e.g. endianness.

The endianness detection has been fixed in the upstream SVN repository 
yesterday, from your comment #10. It now uses macros, and no longer hard-code 
endianness. I will backport the patch in the src.rpm package.

(In reply to comment #8)
> Further issues:
> 
> - The *-devel package ships /usr/include/CORE
> IMO, this directory name is too general.
> 
> - Static libs:
> /usr/lib/libCGALQt.a
> /usr/lib/libcore++.a

These two issue last. And I do not see how to deal with that (especially 
the /usr/include/CORE issue, which cannot be fixed without changing CORE 
documentation and uses).

(In reply to comment #10)
> > CGAL is a meta-package that requires CGAL-libs, CGAL-devel, and 
CGAL-sources. 
> 
> Contradicts Fedora conventions and IMNSOH, is complete non-sense.
> Consider this to be a MUST FIX.
> 
> Put the run-time libs into CGAL or CGAL-libs and the devel files into 
*-devel.

As I said in comment #11, libs already are in CGAL-libs, and devel files are 
in CGAL-devel. I do not understand your point. What is the contradiction with 
Fedora conventions?

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.