[Bug 203190] Review Request: netlabel_tools

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: netlabel_tools


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203190


jkeating at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |NEEDINFO
         AssignedTo|nobody at fedoraproject.org    |jkeating at redhat.com
OtherBugsDependingO|163776                      |163778
              nThis|                            |
               Flag|                            |needinfo?(james.antill at redha
                   |                            |t.com)




------- Additional Comments From jkeating at redhat.com  2006-08-28 17:35 EST -------
NEEDSWORK:
- home_base_url is used exactly once.  Why not just use it in Source0?
- No URL tag
- glibc-kernheaders package doesn't exist anymore.  The new package name is
kernel-headers.  Kernel-headers provides glibc-kernheaders, but might as well
use the new name.
- Description starts with a space
- setup should have -q flag for quiet.
- Package does not build currently:

INFO: entering directory libnetlabel/ ...
 CC netlabel_init.o
In file included from netlabel_init.c:39:
/builddir/build/BUILD/netlabel_tools-0.16/include/linux/netlabel.h:42:1:
warning: "NLMSG_HDRLEN" redefined
In file included from netlabel_init.c:38:
/usr/include/linux/netlink.h:74:1: warning: this is the location of the previous
definition
In file included from netlabel_init.c:39:
/builddir/build/BUILD/netlabel_tools-0.16/include/linux/netlabel.h:45: error:
redefinition of 'struct nlattr'
In file included from netlabel_init.c:39:
/builddir/build/BUILD/netlabel_tools-0.16/include/linux/netlabel.h:64:1:
warning: "NLA_HDRLEN" redefined
In file included from netlabel_init.c:38:
/usr/include/linux/netlink.h:131:1: warning: this is the location of the
previous definition
make[1]: *** [netlabel_init.o] Error 1
make: *** [libnetlabel] Error 2


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.