[Bug 204168] Review Request: libgeda - the library needed by gEDA applications.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libgeda - the library needed by gEDA applications.


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204168





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2006-08-30 10:20 EST -------
Review for libgeda-20060123-5:
Almost okay.

1. From http://fedoraproject.org/wiki/Packaging/Guidelines :

   * Requires
   - Why does libgeda main package require texi2html ?
   = Requires for -devel package is now CORRECT .

   * BuildRequires
   - libXpm-devel libjpeg-devel libpng-devel
                      <- all required by gd-devel
   - fontconfig-devel <- required by pango-devel
                      <- required by gtk2-devel

   * File and Directory Ownership
   - Umm, I don't think that -doc package has to have
     /usr/share/doc/libgeda-doc-20060123/docs directory.
     All files in the directory can be moved to 
     /usr/share/doc/libgeda-doc-20060123/ .

     Perhaps you want to write in -doc file entry

     %doc docs/* , not %docs/

2. From http://fedoraproject.org/wiki/Packaging/ReviewGuidelines :

   = Nothing.

3. The other things I have noticed:

   = Nothing.
   


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.