[Bug 191005] Review Request: glob2 - Realtime Strategy game

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: glob2 - Realtime Strategy game


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191005





------- Additional Comments From j.w.r.degoede at hhs.nl  2006-07-05 13:47 EST -------
The new SRPM indeeds is not corrupted like the old one. This has allowed me to
verify that the source matches upstream, good.

Not so good is this:
mode of `src/CVS' changed to 0644 (rw-r--r--)
chmod: `src/CVS': Permission denied
mode of `src/MainMenuScreen.cpp' changed to 0644 (rw-r--r--)
mode of `src/MainMenuScreen.h' changed to 0644 (rw-r--r--)
mode of `src/MultiplayersChooseMapScreen.cpp' changed to 0644 (rw-r--r--)
mode of `src/MultiplayersChooseMapScreen.h' changed to 0644 (rw-r--r--)
mode of `src/MultiplayersCrossConnectable.cpp' changed to 0644 (rw-r--r--)
mode of `src/MultiplayersCrossConnectable.h' changed to 0644 (rw-r--r--)
mode of `src/MultiplayersOfferScreen.cpp' changed to 0644 (rw-r--r--)
mode of `src/MultiplayersOfferScreen.h' changed to 0644 (rw-r--r--)
error: Bad exit status from /var/tmp/rpm-tmp.93697 (%prep)

After which the build exits I guess you're not seeing this because you build as
root? (bad idea). Anywas change the chmod from:
chmod -Rc -x src/*
to:
chmod -x src/*.cpp src/*.h
Because chmod -x on dirs is a bad idea.

Other items which still need work:
*some of the BR lines are still longer then 80 chars.
*you can drop the requires zlib-devel as that is already required by 
 libpng-devel I missed that the last time because the one long long line 
 approach was kinda impossible to read
*same goes for libX11-devel because its required by libXext-devel
* you still have no version in your changelog, instead of this:
 "* Thu Jul 04 2006 Nikolai <brkamikaze at gmail.com>"
 you dhould write:
 "* Thu Jul 04 2006 Nikolai <brkamikaze at gmail.com> 0.8.19-3"
* You should install all size icons into their appropriate places the whole idea
  behind the sized dirs is that instead of using sometimes ugly software scaling
  there are different handmade sizes of icons available for cases like menu,
  desktop icon and (large/medium/small) panel icon.
* please put empty lines between your different changelog entries, so that the
  changleog looks like this:
%changelog
* Thu Jul 04 2006 Nikolai <brkamikaze at gmail.com>
- Fixed almost all rpmlint errors; can't figure out how to get rid of the 'no-v
- Fixed the desktop file and the icons to use more standard standards :-)

* Tue Jun 27 2006 Nikolai <brkamikaze at gmail.com>
- Added the automake14 to BuildRequires to help 'mocking' the package.

* Sun May 7 2006 Nikolai <brkamikaze at gmail.com>
- First created.



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.