[Bug 197641] Review Request: ode - High performance library for simulating rigid body dynamics

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ode - High performance library for simulating rigid body dynamics


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197641


hugo at devin.com.br changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |




------- Additional Comments From hugo at devin.com.br  2006-07-05 16:07 EST -------
I've got the SRPM and now I'll do the review.

MUST OK:

 * rpmlint returns ok for the ode package. The source does not contain 
documentation for development files, so rpmlint's warning about 
no-documentation on ode-devel should be fine.
 * Package is named according to Packaging Guidelines (following upstream's 
name too)
 * Spec file name matches the base package
 * Package meets Packaging Guidelines
 * Package is legal and licensed under BSD and LGPL, the license field on spec 
matches the source license.
 * License files within the source tarball are packaged as %%doc files.
 * Spec file is in American English and legible :)
 * Source package matches the upstream tarball:
   7afdb1d434a1e2cc2d701fdf8d1f2fad  ode-src-0.6.zip
 * Package builds fine
 * All BR listed fine, no unusued BR listed.
 * Package does not need locale files.
 * The package contains shared libraries and have ldconfig run in %%post 
and %%postun.
 * Package owns all directory it creates, does not own other packages' 
directories.
 * No duplicate files in %%files
 * Permission on packaged files are fine
 * The %%clean section on the spec file is right
 * Spec file uses macros consistently
 * No large documentation files in the package, no need for -doc subpackage.
 * %%doc files does not affect package runtime.
 * Development files are under the -devel subpackage.
 * No pkgconfig files.
 * Devel package requires the base package using a fully versioned dependency
 * No .la files in the packages.
 * No GUI application under the package.

SHOULD OK:

 * No scriptlets use
 * Package build and works fine for i386 and x86_64

I don't see any blockers on this.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.