[Bug 197649] Review Request: gnustep-make - GNUstep makefile package

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gnustep-make -  GNUstep makefile package


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197649





------- Additional Comments From panemade at gmail.com  2006-07-06 02:47 EST -------
== Not an official review as I'm not yet sponsored ==
* Mock build for development i386 is sucessfull with errors as 
** No gnustep-make installation found, attempting to create a local/temporary
one. **
make[2]: texi2pdf: Command not found
make[2]: texi2html: Command not found

  I really got confused over why such errors was shown besides addding texinfo
in BuildRequires.
 
MUST Items:
     - MUST: rpmlint shows same ERRORS as posted by author of package.
     - MUST: dist tag is present
     - MUST: The package is named according to the Package Naming Guidelines.
     - MUST: The spec file name matching the base package gnustep-make, in the
format gnustep-make.spec
      - MUST: This package meets the Packaging Guidelines.
      - MUST: The package is licensed with an open-source compatible license
GPL.
      - MUST: License file COPYING is included in package.
      - MUST: The sources used to build the package matches the upstream source,
as provided in the spec URL. md5sum is correct (1883a6387405e51ff4c384fb5cc547a7).
      - MUST: This package  have a %clean section, which contains rm -rf
$RPM_BUILD_ROOT.
      - MUST: This package used macros.
      - MUST: Document files are included like README.
      - MUST: Package did NOT contained any .la libtool archives.
      * Source URL is present and working.
      * BuildRoot is correct BuildRoot:       
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
      * BuildRequires is correct
   
 Also it will be good to move /usr/local to /usr directory if there is no such
requirement. 
   

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.