[Bug 196629] Review Request: perl-SVK - A Distributed Version Control System

bugzilla at redhat.com bugzilla at redhat.com
Fri Jul 7 00:49:55 UTC 2006 

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-SVK - A Distributed Version Control System


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196629





------- Additional Comments From tibbs at math.uh.edu  2006-07-06 20:41 EST -------
I noticed this during configuration:
  Warning: prerequisite File::Spec 3.18 not found. We have 3.12.
File::Spec is in the core Perl package so updating it isn't really feasible. 
I'm not sure if this causes any problems.

Some rpmlint issues:
E: perl-SVK useless-explicit-provides perl(SVK)
It looks like RPM is screwing up yet again.  I think you'll have to filter this.

W: perl-SVK doc-file-dependency
/usr/share/doc/perl-SVK-1.08/contrib/svk-completion.pl perl(warnings)
W: perl-SVK doc-file-dependency /usr/share/doc/perl-SVK-1.08/contrib/svkopendiff
/bin/sh
Documentation should not be executable.

Some issues with the tests:

t/05svm-lock.................ok
        2/3 skipped: no lock found
Not sure what's up here.

t/06keyword..................ok
        4/27 skipped: fix inconsistent eol-style after commit
This looks like an intentionally skipped test.

t/50dav......................skipped
        all skipped: Apache::Test 1.18 required for testing dav
Not sure if it would make sense to test this without network access.

t/71autovivify...............
Use of uninitialized value in join or string at (eval 62) line 2.

t/72sign.....................skipped
        all skipped: gnupg not found
I added BR: gnupg but the result isn't confidence inspiring.  Perhaps you could
take a look and see if any of that is intended.

I see the rpmlint issues as blockers.

Review:
* source files match upstream:
   92a90bf73dfa958fd3633ec50c5798b1  SVK-1.08.tar.gz
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible.  License text not included upstream.
* latest version is being packaged.
 BuildRequires are proper.
* %clean is present.
* package builds in mock (development, x86_64).
X rpmlint has valid complaints.
* noarch package; no debuginfo.
X final provides and requires are sane:
X  perl(SVK)
   perl(SVK) = 1.08
   perl(SVK::Command)
   perl(SVK::Command::Add)
   perl(SVK::Command::Admin)
   perl(SVK::Command::Annotate)
   perl(SVK::Command::Cat)
   perl(SVK::Command::Checkout)
   perl(SVK::Command::Checkout::detach)
   perl(SVK::Command::Checkout::list)
   perl(SVK::Command::Checkout::purge)
   perl(SVK::Command::Checkout::relocate)
   perl(SVK::Command::Cleanup)
   perl(SVK::Command::Cmerge)
   perl(SVK::Command::Commit)
   perl(SVK::Command::Copy)
   perl(SVK::Command::Delete)
   perl(SVK::Command::Depotmap)
   perl(SVK::Command::Depotmap::add)
   perl(SVK::Command::Depotmap::detach)
   perl(SVK::Command::Depotmap::list)
   perl(SVK::Command::Depotmap::relocate)
   perl(SVK::Command::Describe)
   perl(SVK::Command::Diff)
   perl(SVK::Command::Help)
   perl(SVK::Command::Import)
   perl(SVK::Command::Info)
   perl(SVK::Command::List)
   perl(SVK::Command::Log)
   perl(SVK::Command::Merge)
   perl(SVK::Command::Mirror)
   perl(SVK::Command::Mirror::detach)
   perl(SVK::Command::Mirror::list)
   perl(SVK::Command::Mirror::recover)
   perl(SVK::Command::Mirror::relocate)
   perl(SVK::Command::Mirror::unlock)
   perl(SVK::Command::Mirror::upgrade)
   perl(SVK::Command::Mkdir)
   perl(SVK::Command::Move)
   perl(SVK::Command::Patch)
   perl(SVK::Command::Patch::FileRequired)
   perl(SVK::Command::Patch::apply)
   perl(SVK::Command::Patch::delete)
   perl(SVK::Command::Patch::dump)
   perl(SVK::Command::Patch::list)
   perl(SVK::Command::Patch::regen)
   perl(SVK::Command::Patch::test)
   perl(SVK::Command::Patch::update)
   perl(SVK::Command::Patch::view)
   perl(SVK::Command::Propdel)
   perl(SVK::Command::Propedit)
   perl(SVK::Command::Propget)
   perl(SVK::Command::Proplist)
   perl(SVK::Command::Propset)
   perl(SVK::Command::Pull)
   perl(SVK::Command::Push)
   perl(SVK::Command::Resolved)
   perl(SVK::Command::Revert)
   perl(SVK::Command::Smerge)
   perl(SVK::Command::Status)
   perl(SVK::Command::Switch)
   perl(SVK::Command::Sync)
   perl(SVK::Command::Update)
   perl(SVK::Command::Verify)
   perl(SVK::Editor::Combine)
   perl(SVK::Editor::Delay)
   perl(SVK::Editor::Diff)
   perl(SVK::Editor::Merge)
   perl(SVK::Editor::Patch)
   perl(SVK::Editor::Rename)
   perl(SVK::Editor::Sign)
   perl(SVK::Editor::Status)
   perl(SVK::Editor::Translate)
   perl(SVK::Editor::XD)
   perl(SVK::I18N)
   perl(SVK::Merge)
   perl(SVK::Merge::Info)
   perl(SVK::Notify)
   perl(SVK::Patch)
   perl(SVK::Patch::CommitEditor)
   perl(SVK::Resolve)
   perl(SVK::Resolve::AraxisMerge)
   perl(SVK::Resolve::Emacs)
   perl(SVK::Resolve::FileMerge)
   perl(SVK::Resolve::GVim)
   perl(SVK::Resolve::GtkDiff)
   perl(SVK::Resolve::Guiffy)
   perl(SVK::Resolve::KDiff3)
   perl(SVK::Resolve::Meld)
   perl(SVK::Resolve::P4WinMerge)
   perl(SVK::Resolve::TkDiff)
   perl(SVK::Resolve::TortoiseMerge)
   perl(SVK::Resolve::Vim)
   perl(SVK::Resolve::XXDiff)
   perl(SVK::Target)
   perl(SVK::Target::Universal)
   perl(SVK::Util)
   perl(SVK::VerifyEditor)
   perl(SVK::Version)
   perl(SVK::XD)
   perl(SVK::XD::Root)
   perl(SVK::XD::Signature)
   perl-SVK = 1.08-1.fc6
  =
?  /bin/sh
   /usr/bin/perl
   perl(:MODULE_COMPAT_5.8.8)
   perl(Algorithm::Annotate)
   perl(Algorithm::Diff)
   perl(Class::Autouse)
   perl(Clone)
   perl(Compress::Zlib)
   perl(Config)
   perl(Data::Hierarchy)
   perl(Date::Format)
   perl(Date::Parse)
   perl(Digest::MD5)
   perl(Encode)
   perl(Encode::TW)
   perl(Exporter)
   perl(Fcntl)
   perl(File::Compare)
   perl(File::Copy)
   perl(File::Glob)
   perl(File::Path)
   perl(File::Spec)
   perl(File::Type)
   perl(FreezeThaw)
   perl(Getopt::Long)
   perl(IO::Digest)
   perl(List::Util)
   perl(MIME::Base64)
   perl(PerlIO)
   perl(PerlIO::eol) >= 0.10
   perl(PerlIO::scalar)
   perl(PerlIO::via)
   perl(PerlIO::via::dynamic)
   perl(PerlIO::via::symlink)
   perl(Pod::Escapes)
   perl(Pod::Simple)
   perl(Regexp::Shellish)
   perl(SVK)
   perl(SVK::Command::Log)
   perl(SVK::Command::Sync)
   perl(SVK::Editor::Combine)
   perl(SVK::Editor::Delay)
   perl(SVK::Editor::Diff)
   perl(SVK::Editor::Merge)
   perl(SVK::Editor::Patch)
   perl(SVK::Editor::Rename)
   perl(SVK::Editor::Sign)
   perl(SVK::Editor::Status)
   perl(SVK::Editor::Translate)
   perl(SVK::I18N)
   perl(SVK::Merge)
   perl(SVK::Patch)
   perl(SVK::Target::Universal)
   perl(SVK::Util)
   perl(SVK::Version)
   perl(SVK::XD)
   perl(SVN::Core)
   perl(SVN::Delta)
   perl(SVN::Fs)
   perl(SVN::Ra)
   perl(SVN::Repos)
   perl(SVN::Simple::Edit) >= 0.27
   perl(Sys::Hostname)
   perl(URI)
   perl(YAML)
   perl(autouse)
   perl(base)
   perl(constant)
   perl(strict)
   perl(warnings)
* %check is present and all tests pass:
   All tests successful, 1 test and 6 subtests skipped.
   Files=74, Tests=1439, 136 wallclock secs (51.90 cusr + 16.46 csys = 68.36 CPU)
   Note that this is with BR: gnupg; without it, another test is skipped.
* no shared libraries are present.
* package is not relocatable.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
X file permissions are appropriate (executable documentation)
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no libtool .la droppings.
* not a GUI app.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

More information about the package-review mailing list