[Bug 197967] Review Request: gkrellm - Multiple stacked system monitors in one process

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gkrellm - Multiple stacked system monitors in one process


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197967





------- Additional Comments From ville.skytta at iki.fi  2006-07-14 15:29 EST -------
(In reply to comment #2)
> Sure, that sounds reasonable, how does one pick up the leftover user when the
> user decides to reinstall the package later?

It already works that way due to "|| :" in the useradd/groupadd lines.

> All the changes are wrapped in #ifdef
> HAVE_LIBSENSORS, hence the adding of -DHAVE_LIBSENSORS to CFLAGS. I'll make
> the adding off that conditionally with %ifarch, does that sound ok?

Fine with me; I assume the sensors functionality wasn't available on PPC in
earlier versions either.  Someone who uses this on PPC, please correct if I'm
wrong.  Oh, and BR: lm_sensors-devel needs to be %ifarch'ed too.

> Erm rpmlint complains without it. I'll remove the Provides.

Actually, I think it's time for both Provides/Obsoletes: gkrellm-server to go. 
The obsoletes was added in a patch I submitted almost three years ago (see Oct
09 2003 in %changelog), it was added back then in order to provide clean
upgrades from some 3rd party packages, but I no longer remember the details.

> Are you sure this makes a package self obsoleting?

It does obsolete something that it also provides, and I cannot come up with a
reason why doing so would ever be desirable.  Modern depsolvers probably won't
choke on/ do odd things with that any more though.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.