[Bug 199402] Review Request: chrpath - Modify rpath of compiled programs

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: chrpath - Modify rpath of compiled programs


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199402





------- Additional Comments From dan at danny.cz  2006-07-19 08:44 EST -------
I agree with my pre-reviewer :-) Only the using of %{_smp_flags} is not much
useful when compiling 4 small C files.

Review:
- no rpmlint output on any package
- package name OK
- spec file name OK, is in English and is legible
- package meets the Packaging Guidelines
- license OK (GPL) and is included
- ?source matches upstream? - couldn't be checked due the problems of ftp.hungry.com
- compiles and builds at least on i386 (FC4 and devel)
- no BuildRequires needed
- no localized files
- has no shared lib
- do not create any directory
- no duplicates files, permissions are set properly, uses %defattr
- has %clean section
- consistent use of macros
- contains code
- no large docs, %doc is not required during runtime
- no devel subpackage required, no pkgconfig file
- no .la libtool archives
- not a GUI application
- it works

APPROVED, when you fix the BuildRoot


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.