[Bug 199491] Review Request: dbus-sharp

bugzilla at redhat.com bugzilla at redhat.com
Thu Jul 20 19:58:26 UTC 2006


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: dbus-sharp


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199491





------- Additional Comments From paul at all-the-johnsons.co.uk  2006-07-20 15:49 EST -------
Minor...

Requires: %name = %{version}-%{release}

Should this not be %{name}?

Can the spec unify how it uses $RPM_BUILD_ROOT? It should be either entirely
%{buildroot} or $RPM_BUILD_ROOT but not a mix of the two.

Also, why is the mkdir -p %{_prefix}/lib/mono in the install? The make install
step creates it.

Thanks

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the package-review mailing list