[Bug 198878] Review Request: mutagen - Python module to handle audio metadata

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mutagen - Python module to handle audio metadata


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198878


mr.ecik at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #132774|0                           |1
        is obsolete|                            |




------- Additional Comments From mr.ecik at gmail.com  2006-07-21 04:52 EST -------
Created an attachment (id=132784)
 --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=132784&action=view)
python-mutagen-1.5.1-5.spec

(In reply to comment #9)
> Note: it's nice to the reviewers if you generate a new src.rpm with each
change
> you make to your spec.  That way it's simple to just pull down the new
package
> and build it.

Yes, I know, but I have a slow connection shared on 5 computers in home,
so sending even 296 kB file blocks it completely and I send such files
as rarely as it possible... :/

> You seem to have tickled a new rpmlint warning:
>   W: mutagen mixed-use-of-spaces-and-tabs
> This happened because you indented "noarch" with a tab.  Not a big deal but
that
> means it's easy to fix.

This is odd, because when I checked it in my rpmlint, it didn't show any
errors, but I fixed it in new spec.

> More serious is the name of the package: according to the naming guidelines
this
> package should be named python-mutagen.  See
> http://fedoraproject.org/wiki/Packaging/NamingGuidelines#AddonPython

I don't know how can I overlooked that :/ You're right and I fixed it.

> There's no need to pass CFLAGS to setyp.py since this is a noarch package.

Fixed.

> This package seems to have a test suite, but you don't call it.  You should
> consider adding a section like:
> 
> %check
> %{__python} setup.py coverage

I know, but check procedure looks broken. It shows errors that look like
dependent to errors in check procedure, not in program.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.