[Bug 198882] Review Request: perl-POE-Component-IRC

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-POE-Component-IRC


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198882





------- Additional Comments From rc040203 at freenet.de  2006-07-21 23:31 EST -------
(In reply to comment #11)
> And, as it stands, a happy marriage of the two works...  Leave
> __with_network_tests defined in ~/.rpmmacros or at the command line (or
> undefined, for that matter), and change the conditional test to:
> 
> %check
> %{?__with_network_tests: make test}
> 
> This allows the build to succeed, with or without __with_network_tests defined
> (the original intent, as it were).

I guess I need to be more direct:
- Your approach renders building non-deterministic.
- Your approach trashes ~/.rpmmacros, which can affect subsequent builts.
- Your approach is an ugly hack.

IMO, you are out-smarting yourself.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.