[Bug 199405] Review Request: vtk - The Visualization Toolkit - A high level 3D visualization library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: vtk - The Visualization Toolkit - A high level 3D visualization library


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199405





------- Additional Comments From giallu at gmail.com  2006-07-22 18:30 EST -------
Here is my comments (aka review) on the spec file:

Minor:
* BRs: gcc-c++ and sbin/ldconfig should not be needed
* Group: I think System/Libraries would be more appropriate
* Install: I digged into the cmake build and found that you can simplify the
install part adding:
-DCMAKE_INSTALL_PREFIX=%{buildroot} \
-DVTK_INSTALL_ROOT=%{_prefix} \
This will install stuff in the proper places w/o need for moving stuff around
manually.
* make %{?_smp_mflags} works for me w/o a hitch. I think it should be there

Major:
* non standard buildroot: I believe you asked for a revision on this rule.
Anyway, I saw many other packages were forced to stick to current guidelines, so
I think you have to fix that until the rule changes.

* Duplicate libs: there are a number of libraries included in the package which
we can replaced with system ones. This is done with the flags:

        -DVTK_USE_SYSTEM_EXPAT=ON \
        -DVTK_USE_SYSTEM_FREETYPE=ON \
        -DVTK_USE_SYSTEM_JPEG=ON \
        -DVTK_USE_SYSTEM_PNG=ON \
        -DVTK_USE_SYSTEM_TIFF=ON \
        -DVTK_USE_SYSTEM_ZLIB=ON \

Of course this also adds up for more BRs...

* There is a qt widget and designer plugin available. This is useful for
building qt applications with vtk windows/widgets. To activate it, I added:

        -DVTK_USE_QVTK=ON \
        -DVTK_INSTALL_QT_DIR=%{qt_plugins_prefix} \

where %{qt_plugins_prefix} is:
%define qt_plugins_prefix %(qmake -query QT_INSTALL_PREFIX)/plugins/designer


Moreover, I would appreciate some help understanding the purpose of some
snippets which I am sure you (and many others) understand at first sight, but I
don't. For example I think a comment before:

grep -rl '\.\./\.\./\.\./\.\./VTKData' . | xargs perl -pi
-e's,\.\./\.\./\.\./\.\./VTKData,%{_datadir}/vtkdata-%{version},g'

would help a lot...

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.