[Bug 188461] Review Request: xmms-musepack - Mpegplus (mpc) playback plugin for XMMS

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xmms-musepack - Mpegplus (mpc) playback plugin for XMMS


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=188461


pertusus at free.fr changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pertusus at free.fr




------- Additional Comments From pertusus at free.fr  2006-07-23 18:03 EST -------
Some remarks: 
* the buildroot is not the right one
* although the %define xmms_inputdir with xmms-config isn't clearly 
  wrong I think it should not be done that way, since xmms-config
  must then be present at spec file generation time. Simply having
%define xmms_inputdir %{_libdir}/xmms/Input
  or even replacing %xmms_inputdir with %{_libdir}/xmms/Input would
  seem simpler and cleaner to me
* %setup is missing a -q

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.