[Bug 182254] Review Request: SS5

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: SS5


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=182254





------- Additional Comments From matteo.ricchetti at libero.it  2006-07-24 11:57 EST -------
(In reply to comment #12)
> Using ss5-3.5.4-1.src.rpm
> * Drop the entire Requires line, rpm can figure out this from the 
BuildRequires.
> * some paths are not replaced with RPM macros
>   (wiki: QAChecklist item 7)
> Use macros with all of the file paths in your %files listing. For example,
> %{_mandir} instead of /usr/share/man/. See
> http://fedoraproject.org/wiki/Extras/RPMMacros
> * Delete ss5 from the Summary tag, it is redundant (and fixes rpmlint
> complaining about capitalizing it)
> rpmlint and comments:
> W: ss5 summary-not-capitalized ss5 Socks Server 5
> Will be fixed after remove ss5
> W: ss5 no-version-in-last-changelog
> Put the version number - release at the end of the changelog line
> W: ss5 conffile-without-noreplace-flag /etc/opt/ss5/ss5.conf
> W: ss5 conffile-without-noreplace-flag /etc/opt/ss5/ss5.passwd
> W: ss5 conffile-without-noreplace-flag /etc/pam.d/ss5
> W: ss5 conffile-without-noreplace-flag /etc/rc.d/init.d/ss5
> E: ss5 executable-marked-as-config-file /etc/rc.d/init.d/ss5
> I would mark ss5.conf and ss5.passwd noreplace as they are configuration 
files
> that likely will be edited.
> E: ss5 non-standard-dir-perm /var/log/ss5 0644
> It's expecting something like 755.
> W: ss5 log-files-without-logrotate /var/log/ss5
> Optional.
> W: ss5 service-default-enabled /etc/rc.d/init.d/ss5
> The service is enabled by default after "chkconfig --add"; for security
> reasons, most services should not be. Use "-" as the default runlevel in the
> init script's chkconfig line to fix this if appropriate for this service.
> E: ss5 configure-without-libdir-spec
> A configure script is run without specifying the libdir. configure
> options must be augmented with something like --libdir=%{_libdir}.
> E: ss5 hardcoded-library-path in /usr/lib/ss5/
> A library path is hardcoded to one of the following paths: /lib,
> /usr/lib. It should be replaced by something like /%{_lib} or %{_libdir}.
> Thank you for your patience as we work through these tedious little details.



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.