[Bug 200172] Review Request: freeglut

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: freeglut


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200172





------- Additional Comments From rdieter at math.unl.edu  2006-07-25 17:44 EST -------
* upstream source checks out:
6d16873bd876fbf4980a927cfbc496a1  freeglut-2.4.0.tar.gz

MUSTFIX items:
1.  Drop
BuildRequires: /sbin/ldconfig
(it's pretty much already a given)
Requires(post): /sbin/ldconfig
Requires(postun): /sbin/ldconfig
(rpm automatically picks these up)

2. Drop the 
CFLAGS="$RPM_OPT_FLAGS -Wall $(pkg-config --cflags glib)
it's not needed.  At some point in the past, freeglut may have had references to
glib's header files, but it doesn't anymore (I checked).

3.  omit static lib using 
%configure --disable-static
and drop from %files
%{_libdir}/lib*.a

4.  Optional.  Be careful about the Obsoletes/Provides.  It seemingly Obsoletes
itself using:
Obsoletes: glut <= 3.7
Provides:  glut  = 3.7
maybe use something safer like:
Obsoletes: glut < 3.7-%{release}
Provides:  glut = 3.7-%{release}
(and likewise for the Ob/Pr for glut-devel)

Or heck, drop the glut Obsoletes/Provides bits altogether, isn't glut pretty
much ancient history anyway?  (:


Fix 1-3, and I'll approve this.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.